Repository navigation
ENH: allow suspicious-looking reasons in skip when passed as keyword without warning - #15367
Open
neutrinoceros wants to merge 1 commit into
Open
neutrinoceros wants to merge 1 commit into
neutrinoceros wants to merge 1 commit into
Conversation
neutrinoceros
force-pushed
the
enh/no-warning-skip-w-kwarg-reason
branch
from
November 10, 2026 08:05
0942f2a to
35a6af5
Compare
Contributor
Author
|
I guess it probably doesn't make sense to add a changelog entry for this as a change to an unreleased feature, but maybe I should update the one from gh-15252 ? |
1 of 2 tasks
RonnyPfannschmidt
added
the
skip news
RonnyPfannschmidt
approved these changes
Nov 10, 2026
| f""" | ||
| import pytest | ||
|
|
||
| @pytest.mark.skip({reason=!r}) |
Member
There was a problem hiding this comment.
at first glance that format string looks wrong, the equals form is something one has to get used to 🦺
Contributor
Author
There was a problem hiding this comment.
Would you prefer the following, equivalent form ?
Suggested change
| @pytest.mark.skip({reason=!r}) | |
| @pytest.mark.skip(reason={reason!r}) |
(for reference, the syntax I used was introduced in Python 3.8)
Member
There was a problem hiding this comment.
It's fine as is im just bemused that the "new" syntax looks "wrong " to me
neutrinoceros
marked this pull request as ready for review
November 10, 2026 09:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #15366