Fix off-by-one in trailing assertion diff skipping (#14637)#14639
Open
Aditya-Tripuraneni wants to merge 3 commits into
Open
Fix off-by-one in trailing assertion diff skipping (#14637)#14639Aditya-Tripuraneni wants to merge 3 commits into
Aditya-Tripuraneni wants to merge 3 commits into
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
Aditya-Tripuraneni
force-pushed
the
fix-14637-trailing-skip-off-by-one
branch
from
a06ffb0 to
71f3403
Compare
Author
|
@RonnyPfannschmidt could I please get a reviewal for this? |
Pierre-Sassoulas
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14637
Fix an off-by-one in trailing text diff skipping so pytest compares from the last character first instead of accidentally checking the first character via
-0.This adds a regression test for the case where the compared strings differ at the beginning but share a long identical trailing suffix, and includes a changelog entry.
Thanks to @EternalRights for finding and reporting this bug.