Skip to content

Refactor marks to get rid of the current "marks transfer" mechanism #2363

Description

@nicoddemus

Marks currently are transferred between nested Python objects after collection, by mutating the objects themselves. For example, marks applied to classes are copied over all the test methods of the class, being added as attributes of the methods themselves.

This approach brings with it some surprising problems and is hard to get it right (#199, #842 and probably many others which have been fixed along the years).

@RonnyPfannschmidt has proposed to get rid of the current mark transfer mechanism in favor of a new one where marks are transfered from parent items to children, instead of mutating the Python objects.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic: marksrelated to marks, either the general marks or builtintype: proposalproposal for a new feature, often to gather opinions or design the API around the new featuretype: refactoringinternal improvements to the code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions