Repository navigation
Support spying on async callable objects - #652
Open
mehdimirzafaruk wants to merge 1 commit into
Open
mehdimirzafaruk wants to merge 1 commit into
mehdimirzafaruk wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mocker.spyrecognizes coroutine functions, but not objects whose__call__method is async. Those objects currently get aMagicMock, so calls still return an awaitable and appear to work, but await assertions such asassert_awaited_once_withare unavailable andspy_returnrecords the coroutine rather than its resolved value.Detect an async
__call__and useAsyncMockfor that non-autospecced target. This followsunittest.mockasync semantics while preserving the existing autospec path for functions and methods.The regression test uses a class-level async callable attribute. It fails on
mainbecause the spy is aMagicMock, and passes with the fix.Validation:
TestSpy: 21 passedmainand this branchgit diff --checkpassedThis is separate from #650, which changes context-manager warning behavior.