chore(structure): split hook modules into role-specific files - #703
Open
RonnyPfannschmidt wants to merge 2 commits into
Open
chore(structure): split hook modules into role-specific files#703RonnyPfannschmidt wants to merge 2 commits into
RonnyPfannschmidt wants to merge 2 commits into
Conversation
RonnyPfannschmidt
force-pushed
the
refactor/split-hook-modules
branch
from
July 24, 2026 16:53
8c3f2f7 to
7489fdb
Compare
RonnyPfannschmidt
force-pushed
the
refactor/split-hook-modules
branch
3 times, most recently
from
August 12, 2026 11:14
f795cf2 to
fcece74
Compare
This was referenced Aug 12, 2026
Open
RonnyPfannschmidt
marked this pull request as ready for review
September 9, 2026 20:20
Closed
Add the design/ writeup chain (decisions + per-step docs 01-07) that guides the stacked refactoring branches. Exclude design/ from blacken-docs since the docs use elided pseudo-code signatures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RonnyPfannschmidt
force-pushed
the
refactor/split-hook-modules
branch
from
September 12, 2026 19:04
fcece74 to
451ce94
Compare
Move hook types, markers, callers, implementations, and multicall out of the monolithic _hooks/_callers modules so later typed-config and CompletionHook work can land without thrashing one huge file. Keep _hooks and _callers as re-export shims for import compatibility. Co-authored-by: Cursor AI <ai@cursor.sh> Co-authored-by: Cursor Grok 4.5 <grok@cursor.com>
RonnyPfannschmidt
force-pushed
the
refactor/split-hook-modules
branch
from
September 12, 2026 19:14
451ce94 to
d1439c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written with AI assistance (Cursor, then Claude Code). I reviewed it and I'm posting it.
Step 1 of 7 — bottom of the stack, targets
main, mergeable on its own.#703 → #704 → #706 → #707 → #708 → #709 → #710
Per-step review discussion lives on the fork: #6 (this step), then #5, #7, #8, #9, #10, #11.
_hooks.pyhad grown to hold the option types, both markers,HookSpec,HookImpl, andHookCallerat once. This splits it, and_callers.py, along role lines:_configHookspecOpts,HookimplOpts,normalize_hookimpl_opts_decoratorsHookspecMarker,HookimplMarker,HookSpec,varnames_implementationHookImpl_callerHookCaller,_SubsetHookCaller,HookRelay_execution_multicalland the wrapper/teardown helpers_hooksand_callersstay as re-export shims, so every existing import — including the private ones pytest and others reach for — keeps working.Pure code movement, no behavior change. The point is to give the later steps (typed config objects,
CompletionHook, a ProtocolHookCaller) somewhere to land without each one also being a reorganization.Also carries
design/: the writeups for all seven steps, so the rationale sits next to the code rather than in the PR log.