Skip to content

fix(mobile): commit font-size changes when dragging finishes - #382

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-09-07-mobile-font-slider
Sep 7, 2026
Merged

fix(mobile): commit font-size changes when dragging finishes#382
rynfar merged 1 commit into
pylonfrom
upstream/2026-09-07-mobile-font-slider

Conversation

@rynfar

@rynfar rynfar commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Dragging a font-size slider writes preferences and reapplies global typography for every intermediate value, which can lag or trigger React's maximum update depth error. Keep the thumb and fill responsive in Reanimated while dragging, then commit the snapped value once on release. A cancelled drag returns to the saved size; taps and accessibility adjustments still commit immediately.

Adopts pingdotgg/t3code#7138 (062987b2fb0ef48cc7776d654931bd9f3bcf1f9f). Pylon's symbol component, theme integration, preferences, and fingerprint policy remain. This applies to mobile appearance settings on iOS and Android; web/desktop and provider/connection behavior are unaffected.

Validation: the mobile package's tsc --noEmit and scoped lint pass. On iOS 26.3, the same three-second slider gesture invoked the real preference-update callback five times before (17–21 pt), and once after (21 pt). The committed size was confirmed through the native accessibility snapshot. A tap changed the value immediately; accessibility decrements worked; the original 16-point preference and Pylon/system theme were restored. Temporary measurement logging was removed. Android shares this component and typecheck coverage; no Android gesture run is claimed.

Before After
Before After

Before gesture recording · After gesture recording.

Model: GPT-6 Astra. Harness: Codex.

… update depth errors (#7138)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit 062987b2fb0ef48cc7776d654931bd9f3bcf1f9f)
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.7 KiB 13.8 KiB +172 B (+1.2%) 15.1 KiB
Codex Thread snapshot wire 7.1 KiB 7.1 KiB −8 B (−0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.6 KiB 6.7 KiB +180 B (+2.7%) 7.8 KiB
Codex Live turn WebSocket decoded 56.5 KiB 57.4 KiB +910 B (+1.6%) 66.4 KiB
Codex Live turn messages 8 10 +2 (+25.0%) 21
Claude Total thread wire 13.6 KiB 13.7 KiB +53 B (+0.4%) 15.1 KiB
Claude Thread snapshot wire 7.1 KiB 7.1 KiB +5 B (+0.1%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.6 KiB +48 B (+0.7%) 7.8 KiB
Claude Live turn WebSocket decoded 57.3 KiB 57.3 KiB +44 B (+0.1%) 66.4 KiB
Claude Live turn messages 7 8 +1 (+14.3%) 21

Baseline: 983633a · PR result: d1c0734 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 111.2 KiB
  • Claude decoded thread snapshot: 111.9 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar marked this pull request as ready for review September 7, 2026 09:03
@rynfar
rynfar merged commit a3b48fc into pylon Sep 7, 2026
19 checks passed
@rynfar
rynfar deleted the upstream/2026-09-07-mobile-font-slider branch September 7, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants