fix(mobile): commit font-size changes when dragging finishes - #382
Merged
Conversation
… update depth errors (#7138) Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit 062987b2fb0ef48cc7776d654931bd9f3bcf1f9f)
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a font-size slider writes preferences and reapplies global typography for every intermediate value, which can lag or trigger React's maximum update depth error. Keep the thumb and fill responsive in Reanimated while dragging, then commit the snapped value once on release. A cancelled drag returns to the saved size; taps and accessibility adjustments still commit immediately.
Adopts pingdotgg/t3code#7138 (
062987b2fb0ef48cc7776d654931bd9f3bcf1f9f). Pylon's symbol component, theme integration, preferences, and fingerprint policy remain. This applies to mobile appearance settings on iOS and Android; web/desktop and provider/connection behavior are unaffected.Validation: the mobile package's
tsc --noEmitand scoped lint pass. On iOS 26.3, the same three-second slider gesture invoked the real preference-update callback five times before (17–21 pt), and once after (21 pt). The committed size was confirmed through the native accessibility snapshot. A tap changed the value immediately; accessibility decrements worked; the original 16-point preference and Pylon/system theme were restored. Temporary measurement logging was removed. Android shares this component and typecheck coverage; no Android gesture run is claimed.Before gesture recording · After gesture recording.
Model: GPT-6 Astra. Harness: Codex.