fix(codex): show affected paths in file approval requests - #337
Merged
Conversation
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> (cherry picked from commit 57a6b70e24221f00c9a161f1e5b6b2ddd753bc8f)
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
rynfar
marked this pull request as ready for review
September 7, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex file-change approval requests sometimes omit a reason, leaving the card without useful detail. Use the supplied file operations and paths, or the write root, when no reason is available. Keep explicit reasons and bound the file list to 20 entries plus a remaining count.
Adopts upstream #8669,
57a6b70e24221f00c9a161f1e5b6b2ddd753bc8f. Existing approval decisions and wire contracts are unchanged.Validation: 78 Codex adapter/session-runtime tests, server typecheck, and targeted lint pass.
Integrated browser verification: the actual Pylon approval card renders synthetic payloads matching the adapter’s old empty detail and new sorted file-change fallback. No approval was submitted. The adapter tests verify the provider-to-detail mapping.
Before:
After:
Model: GPT-6 Astra. Harness: Codex.