Merged
Conversation
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
cyyever
changed the title
cyyever
changed the title
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
cyyever
force-pushed
the
readibility_26
branch
6 times, most recently
from
ff009c0 to
5e6a858
Compare
Signed-off-by: cyy <cyyever@outlook.com>
cyyever
force-pushed
the
readibility_26
branch
from
5e6a858 to
d846515
Compare
rwgk
approved these changes
Dec 8, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Nice, thanks!
I'm surprised that the cast in init_holder_from_existing is redundant, but all tests pass (except the known broken ones), so clang-tidy must be correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds readability-redundant-casting and readability-redundant-casting from clang-tidy, and applies their fixes.
Suggested changelog entry: