Repository navigation
Introduce pybind11::detail::is_move_constructible - #4630
Merged
Merged
Conversation
To support the use case captured in the new test_vector_unique_ptr_member.cpp
Collaborator
Author
|
Google-internal global test ID: OCL:525899159:BASE:526066520:1682096245207:c46a5bea (Passed) |
rwgk
marked this pull request as ready for review
April 21, 2023 17:06
wangxf123456
approved these changes
Apr 21, 2023
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 18, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 18, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 18, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 18, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 18, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 18, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 19, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 19, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 19, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 22, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
wangxf123456
pushed a commit
to google/clif
that referenced
this pull request
May 22, 2023
BEGIN_PUBLIC New clif/testing/python:vector_unique_ptr_member_test END_PUBLIC Follow-on to: * pybind/pybind11#4630 — Introduce `pybind11::detail::is_move_constructible` * cl/526123390 — Generate is_move_constructible<T>: std::false_type to tell pybind11 that T is not movable. Originally reduced from: ``` blaze build //waymo/planner/evaluation/metrics/time_to_encroachment/encroachment_utils/python:potential_collision_severity_calculator_clif ``` Manually tested with `_GEN_PYBIND11 = True` in devtools/clif/python/clif_build_rule.bzl: * http://sponge2/200da41a-fdd0-4e0e-a3e7-8fd00294b84d PiperOrigin-RevId: 526133273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To support the use case captured in the new test_vector_unique_ptr_member.cpp
This is very similar to the existing
pybind11::detail::is_copy_constructible.Suggested changelog entry: