Repository navigation
fix: support DEBUG in environment - #53
Merged
Merged
Conversation
henryiii
force-pushed
the
henryiii-patch-1
branch
from
August 3, 2021 14:49
c408969 to
e2fce2f
Compare
ax3l
reviewed
Aug 11, 2021
| def build_extension(self, ext): | ||
| extdir = os.path.abspath(os.path.dirname(self.get_ext_fullpath(ext.name))) | ||
|
|
||
| # required for auto-detection of auxiliary "native" libs |
Contributor
There was a problem hiding this comment.
Do you want to remove the comment? I found this a bit surprising why this is needed, so I added it.
Collaborator
Author
There was a problem hiding this comment.
I was looking at a Python 3 only version, which has the end separator automatically (due to pathlib) and has less need of the comment. Don't think I really intended to remove the comment here.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few updates on rereading, and support for DEBUG being set in the environment.