Repository navigation
0.14.2-1 - #33
Merged
Merged
0.14.2-1#33
Conversation
pwwang
commented
Nov 9, 2026
pwwang
commented
Owner
- fix(VelocityPlot): scale linewidth, not size, for stream plot type
The stream branch maps the streamline thickness as an aesthetic,
`linewidth = after_stat(step)`, but the accompanying scale was
`scale_size(range = range(streamline_width), guide = "none")`. A `size` scale cannot
act on a `linewidth` mapping, so:
- `streamline_width` had no effect at all -- c(0, 0.1) rendered identically to the
default c(0, 0.8), byte for byte;
- ggplot's default continuous linewidth scale (roughly 1-6) applied instead, which is
why streamlines rendered as thick ribbons that covered the cells underneath;
- the `guide = "none"` was attached to the wrong scale, so an unhelpful "step" legend
appeared next to the plot.
Use `scale_linewidth(range = range(streamline_width), guide = "none")` instead. The
default range c(0, 0.8) now really is the maximum stroke width, so streams are thin by
default and `streamline_width` tunes them.
Adds a regression test that compares the scaled layer's line width at two widths. The
previous test only asserted `expect_s3_class(p, "ggplot")`, which passed throughout.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.