You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
deprecate king from get_total_irradiance and get_sky_diffuse? #2897
Describe the bug @cbcrespo introduced the deprecation of pvlib.irradiance.king in #2783. Should this be complemented with removing king from the model list in irradiance.get_total_irradiance (link) and irradiance.get_sky_diffuse (link)?
Good catch, I forgot or didn't see/check v0.16 deprecations. Adding to #2396.
Should this be complemented with removing king from the model list in irradiance.get_total_irradiance (link) and irradiance.get_sky_diffuse (link)?
If anybody uses them now, it should raise the deprecation warning if I'm not mistaken. So in the removal version, these lists/code branches should be also removed without any problems.
Describe the bug
@cbcrespo introduced the deprecation of
pvlib.irradiance.kingin #2783. Should this be complemented with removingkingfrom the model list inirradiance.get_total_irradiance(link) andirradiance.get_sky_diffuse(link)?