Skip to content

deprecate king from get_total_irradiance and get_sky_diffuse? #2897

Description

@ramaroesilva

Describe the bug
@cbcrespo introduced the deprecation of pvlib.irradiance.king in #2783. Should this be complemented with removing king from the model list in irradiance.get_total_irradiance (link) and irradiance.get_sky_diffuse (link)?

Activity

  1. echedey-ls commented on Oct 10, 2026

    @echedey-ls
    Member

    Good catch, I forgot or didn't see/check v0.16 deprecations. Adding to #2396.

    Should this be complemented with removing king from the model list in irradiance.get_total_irradiance (link) and irradiance.get_sky_diffuse (link)?

    If anybody uses them now, it should raise the deprecation warning if I'm not mistaken. So in the removal version, these lists/code branches should be also removed without any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions