You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From what i can tell, this issue is about using (what's now called) Effect.Uncurried (EffectFnX) instead of FnX and mkEffect. The use of mkEffect prevents things like #27 by my understanding, but it's still an old and convoluted way of doing things. Perhaps we could switch over to EffectFnX at the same time as changes for #19 are made.
My intention when I created this was only to change the implementations internally, not to change the type signatures of any exported functions - I don't think we should use EffectFn in the exported functions in this library.
Reacted by JordanMartinez, artemisSystem and Colin Wahl
I'm in agreement with making this breaking change to this library outside of the normal ecosystem breakage. With the advent of purs-backend-es, some things can't be optimized without this.
Activity
paf31 commentedon Mar 7, 2016
👍
artemisSystem commentedon May 20, 2022
From what i can tell, this issue is about using (what's now called)
Effect.Uncurried(EffectFnX) instead ofFnXandmkEffect. The use ofmkEffectprevents things like #27 by my understanding, but it's still an old and convoluted way of doing things. Perhaps we could switch over toEffectFnXat the same time as changes for #19 are made.JordanMartinez commentedon May 20, 2022
I was thinking the same thing when I reviewed your other PR. We should be using
EffectFnXnow.[-]use eff-functions[/-][+]Use `EffectFnX` functions[/+]hdgarrood commentedon May 20, 2022
My intention when I created this was only to change the implementations internally, not to change the type signatures of any exported functions - I don't think we should use
EffectFnin the exported functions in this library.[-]Use `EffectFnX` functions[/-][+]Use `EffectFnX` functions internally[/+]artemisSystem commentedon May 20, 2022
Agreed
colinwahl commentedon Oct 18, 2022
I ran into a case where the current unsafe
mkEffectutil causes a runtime error when running this code through purescript-backend-optimizer. There is some discussion on why: aristanetworks/purescript-backend-optimizer#29I'd be happy to make this change if no one else is working on it at the moment.
JordanMartinez commentedon Oct 18, 2022
I'm in agreement with making this breaking change to this library outside of the normal ecosystem breakage. With the advent of
purs-backend-es, some things can't be optimized without this.@colinwahl Go for it!
colinwahl commentedon Oct 18, 2022
This shouldn't be a breaking change - none of the values whose types are changing are exported, and the exported values all retain their same types.
JordanMartinez commentedon Oct 18, 2022
Oh nice! I wasn't aware of that.