Skip to content

Use EffectFnX functions internally #28

Closed

Description

@hdgarrood

To prevent issues like #27 from occurring again.

Activity

  1. paf31 commented on Mar 7, 2016

    @paf31
    Contributor

    👍

  2. artemisSystem commented on May 20, 2022

    @artemisSystem
    Contributor

    From what i can tell, this issue is about using (what's now called) Effect.Uncurried (EffectFnX) instead of FnX and mkEffect. The use of mkEffect prevents things like #27 by my understanding, but it's still an old and convoluted way of doing things. Perhaps we could switch over to EffectFnX at the same time as changes for #19 are made.

  3. JordanMartinez commented on May 20, 2022

    @JordanMartinez
    Contributor

    I was thinking the same thing when I reviewed your other PR. We should be using EffectFnX now.

  4. changed the title [-]use eff-functions[/-] [+]Use `EffectFnX` functions[/+] on May 20, 2022
  5. hdgarrood commented on May 20, 2022

    @hdgarrood
    MemberAuthor

    My intention when I created this was only to change the implementations internally, not to change the type signatures of any exported functions - I don't think we should use EffectFn in the exported functions in this library.

  6. added
    good first issueFirst-time contributors who are looking to help should work on these issues.
    status: acceptedThis issue is now ready to be implemented via a PR.
    type: housekeepingRepo-related things (e.g. fixing CI) that need to be done.
    and removed
    status: needs more infoThis issue needs more info before any action can be done.
    type: breaking changeA change that requires a major version bump.
    on May 20, 2022
  7. changed the title [-]Use `EffectFnX` functions[/-] [+]Use `EffectFnX` functions internally[/+] on May 20, 2022
  8. artemisSystem commented on May 20, 2022

    @artemisSystem
    Contributor

    Agreed

  9. colinwahl commented on Oct 18, 2022

    @colinwahl
    Contributor

    I ran into a case where the current unsafe mkEffect util causes a runtime error when running this code through purescript-backend-optimizer. There is some discussion on why: aristanetworks/purescript-backend-optimizer#29

    I'd be happy to make this change if no one else is working on it at the moment.

  10. JordanMartinez commented on Oct 18, 2022

    @JordanMartinez
    Contributor

    I'm in agreement with making this breaking change to this library outside of the normal ecosystem breakage. With the advent of purs-backend-es, some things can't be optimized without this.

    @colinwahl Go for it!

  11. colinwahl commented on Oct 18, 2022

    @colinwahl
    Contributor

    This shouldn't be a breaking change - none of the values whose types are changing are exported, and the exported values all retain their same types.

  12. JordanMartinez commented on Oct 18, 2022

    @JordanMartinez
    Contributor

    This shouldn't be a breaking change - none of the values whose types are changing are exported, and the exported values all retain their same types.

    Oh nice! I wasn't aware of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueFirst-time contributors who are looking to help should work on these issues.status: acceptedThis issue is now ready to be implemented via a PR.type: housekeepingRepo-related things (e.g. fixing CI) that need to be done.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions