Skip to content

Address Melissa Amos's feedback. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfagerlund merged 3 commits into from
Apr 19, 2016
Merged

Address Melissa Amos's feedback. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a93fa8
Increase h1 size to match main site, and color strong tags in headings.
gguillotte Apr 18, 2016
619ac89
Adjust space between ol numerals and items.
gguillotte Apr 18, 2016
e89836f
Fix color in strong headings.
gguillotte Apr 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions less/puppetdocs.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,17 @@ b, strong {
font-weight: @font-weight-bold;
}

h1,
h2,
h3,
h4,
h5,
h6 {
& strong {
color: @brand-amber;
}
}

a {
font-weight: @font-weight-medium;
}
Expand Down
8 changes: 8 additions & 0 deletions less/type.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,14 @@ ol {
}
}

// Re-align ol items to match ul items.
ol {
padding-left: 2rem;
li {
padding-left: 0.5rem;
}
}

// List options

// Unstyled keeps list items block level, just removes default browser padding and list-style
Expand Down
2 changes: 1 addition & 1 deletion less/variables.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
@font-size-large: (@font-size-base * 1.25); // ~22px
@font-size-small: (@font-size-base * 0.836364); // ~14.72px

@font-size-h1: (@font-size-base * 2.6); // ~46px
@font-size-h1: (@font-size-base * 2.9); // ~51px
@font-size-h2: (@font-size-base * 2.15); // ~38px
Copy link
Copy Markdown

@melamos melamos Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make H2-H4 smaller, and more differentiated, rather than increasing the size of the H1? These fonts are all rather huge. With a longish title, the H2s extend to two or sometimes three lines, like here: https://docs.puppet.com/pe/latest/release_notes_known_issues_console.html. It's also difficult to distinguish between H2 and H3, like here: https://docs.puppet.com/pe/latest/install_agents.html. You have to really be paying attention to font size to recognize that the H3s are children. Because we don't use indenting to indicate document structure, it seems important that the heading levels are very clearly distinguishable.

@font-size-h3: (@font-size-base * 1.7); // ~30px
@font-size-h4: (@font-size-base * 1.25); // ~22px
Expand Down