Skip to content

Fix pull-through caching failing for improper named packages#1084

Merged
gerrod3 merged 1 commit intopulp:mainfrom
gerrod3:pt-no-version-fix
Feb 6, 2026
Merged

Fix pull-through caching failing for improper named packages#1084
gerrod3 merged 1 commit intopulp:mainfrom
gerrod3:pt-no-version-fix

Conversation

@gerrod3
Copy link
Copy Markdown
Contributor

@gerrod3 gerrod3 commented Jan 29, 2026

fixes: #1040
Assisted by: claude-4.5-sonnet

@gerrod3 gerrod3 requested a review from jobselko February 4, 2026 16:40
@gerrod3 gerrod3 merged commit 6008980 into pulp:main Feb 6, 2026
23 of 27 checks passed
@patchback
Copy link
Copy Markdown

patchback Bot commented Feb 6, 2026

Backport to 3.24: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.24/6008980c5f36435fc2d019c4c150994f1fb07114/pr-1084

Backported as #1088

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Feb 6, 2026
Fix pull-through caching failing for improper named packages

(cherry picked from commit 6008980)
@gerrod3 gerrod3 deleted the pt-no-version-fix branch February 6, 2026 17:25
gerrod3 added a commit that referenced this pull request Feb 6, 2026
…f36435fc2d019c4c150994f1fb07114/pr-1084

[PR #1084/6008980c backport][3.24] Fix pull-through caching failing for improper named packages
@patchback
Copy link
Copy Markdown

patchback Bot commented Apr 29, 2026

Backport to 3.19: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 6008980 on top of patchback/backports/3.19/6008980c5f36435fc2d019c4c150994f1fb07114/pr-1084

Backporting merged PR #1084 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulp_python.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.19/6008980c5f36435fc2d019c4c150994f1fb07114/pr-1084 upstream/3.19
  4. Now, cherry-pick PR Fix pull-through caching failing for improper named packages #1084 contents into that branch:
    $ git cherry-pick -x 6008980c5f36435fc2d019c4c150994f1fb07114
    If it'll yell at you with something like fatal: Commit 6008980c5f36435fc2d019c4c150994f1fb07114 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 6008980c5f36435fc2d019c4c150994f1fb07114
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix pull-through caching failing for improper named packages #1084 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.19/6008980c5f36435fc2d019c4c150994f1fb07114/pr-1084
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull-through cache mode fails for some projects on pypi.org

2 participants