Skip to content

FE: Fix permissions check for cluster edit#3862

Merged
iliax merged 1 commit intomasterfrom
issues/3835
May 25, 2023
Merged

FE: Fix permissions check for cluster edit#3862
iliax merged 1 commit intomasterfrom
issues/3835

Conversation

@Haarolean
Copy link
Copy Markdown
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
FE: Fix permissions check for cluster edit. Closes #3835

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/bug Something isn't working scope/frontend type/regression Something that has been previously fixed but got broken again labels May 24, 2023
@Haarolean Haarolean self-assigned this May 24, 2023
@Haarolean Haarolean requested a review from a team as a code owner May 24, 2023 14:47
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@iliax iliax merged commit 71a7a1e into master May 25, 2023
@iliax iliax deleted the issues/3835 branch May 25, 2023 05:37
@Haarolean Haarolean mentioned this pull request Jun 9, 2023
4 tasks
Haarolean added a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/frontend type/bug Something isn't working type/regression Something that has been previously fixed but got broken again

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FE: Regression: Configure cluster buttons are disabled with RBAC tooltip even if there's no RBAC enabled

3 participants