Fix sed substitute issues for FServer, Cisco, and Yamaha MIBs#1595
Open
aymanbagabas wants to merge 1 commit intoprometheus:mainfrom
Open
Fix sed substitute issues for FServer, Cisco, and Yamaha MIBs#1595aymanbagabas wants to merge 1 commit intoprometheus:mainfrom
aymanbagabas wants to merge 1 commit intoprometheus:mainfrom
Conversation
This change addresses several issues with the MIB files downloaded by the Makefile. Now, it uses perl for more robust multi-line substitutions that works on all platforms. Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
aymanbagabas
force-pushed
the
substitute-issues
branch
from
e462425 to
f201599
Compare
SuperQ
requested changes
Mar 22, 2026
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
I think we'd rather migrate these to patch files like is being done for the Synology MIB.
I'd rather not have perl as a build dependency just for MIB tweaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses several issues with the MIB files downloaded by the Makefile. Now, it uses perl for more robust multi-line substitutions that works on all platforms.