2.3.2 Patch: Loading animation & Performance improvements - #9028
Merged
Conversation
…g text with a basic animation.
…unit test for the loading indicator to work with the updated loading.js file.
…ing indicator, "this" is referenced so that every p5 instance has their own loading indicator. Also changed the animation and style names to include "p5"
…the center of the webpage.
Optimize the 2D shape hot path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a recent addition of loading animation to the
stablebranch. This is part of an updated release process, where patches can be much smaller, and quicker to test and release, while active development takes place on themainbranch. Additional PRs updating contributor docs and inviting feedback are coming soon, but this is the initial trial of the setup, following maintainers development planning from July 21st.In this patch:
Current release process docs:
Having very small, micro-releases for patches is consistent with this approach. Then, minor release notes would include everything and a more integrated description.