chore(cli): bump @prisma/compute-sdk to 0.34.0 (Windows PATH fix)#116
Merged
Conversation
Picks up the Windows PATH env-key fix (project-compute#105): buildCommandEnv now resolves the PATH key case-insensitively, so app build/deploy no longer fail with "'bun' is not recognized" on Windows. Also refreshes the lockfile, which was still resolving 0.31.0 despite the 0.33.0 pin.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThis change updates the version of the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@prisma/compute-sdk0.33.0 -> 0.34.0 to pick up the Windows build fix (project-compute#105, published as 0.34.0).What this fixes
On Windows,
prisma-cli app buildandapp deployfailed immediately with'bun' is not recognized as an internal or external commandeven with Bun installed. The SDK'sbuildCommandEnvwrote a literalPATHkey over Windows'Path-cased variable, forking a duplicate key whose bin-dirs-only value shadowed the real system PATH in the spawned build shell. 0.34.0 resolves the key case-insensitively and extends it in place.Supersedes #115, which patched the same bug CLI-side; the root cause is SDK-owned.
Notes
packages/cli/package.json; this refresh brings the installed version in line with the manifest..cmdlauncher ladder and awindows-latestCI leg.