Repository navigation
fix(three): keep web springs animating when @react-spring/three is imported - #2602
Draft
joshuaellis wants to merge 1 commit into
Draft
joshuaellis wants to merge 1 commit into
joshuaellis wants to merge 1 commit into
Conversation
…ported Importing @react-spring/three switched the shared frame loop to React Three Fiber's demand mode, so every spring in the app froze while no Canvas was rendering. Three now drives a clock of its own: springs from @react-spring/three follow React Three Fiber's frames, and springs from @react-spring/web keep following the browser. Resolves #1586
🦋 Changeset detectedLatest commit: 76b5918 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Docs preview: https://pr-2602---react-spring-204644970562.europe-west1.run.app Deployed at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Importing
@react-spring/threeno longer freezes springs from@react-spring/webwhile no Canvas is rendering. Springs now follow the package they come from: three springs follow React Three Fiber's frames, including XR andadvance()withframeloop="never", and web springs follow the browser.Before, three switched the one shared frame loop into React Three Fiber's demand mode as soon as it was imported, so every spring in the app waited for a Canvas to render.
Globals.assignclock options,raf.advance()andupdate()now only reach web springs.Resolves #1586