Repository navigation
refactor: give each clock its own frame loop and queues - #2601
Draft
joshuaellis wants to merge 1 commit into
Draft
joshuaellis wants to merge 1 commit into
joshuaellis wants to merge 1 commit into
Conversation
rafz and the frame loop were module singletons, so a target that drives frames its own way (three follows React Three Fiber) changed how every spring in the app ticked. Schedulers and frame loops are now created by factories, and every spring, controller and interpolation runs on the clock it was created on. Only the default clock exists so far, so nothing changes yet.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Each spring, controller and interpolation now runs on the clock it was created on, so a target can drive its own springs without stalling anyone else's. Every spring still gets the one default clock that
Globals.assignconfigures, so nothing changes yet.The scheduler and frame loop were module singletons, so when
@react-spring/threeswitched them to React Three Fiber's demand mode, springs from@react-spring/webfroze while no Canvas was rendering (#1586).