Skip to content

Update percy tests to use maps#4743

Merged
LiamConnors merged 4 commits into
masterfrom
update-percy-tests
Sep 19, 2024
Merged

Update percy tests to use maps#4743
LiamConnors merged 4 commits into
masterfrom
update-percy-tests

Conversation

@LiamConnors
Copy link
Copy Markdown
Contributor

@LiamConnors LiamConnors commented Aug 30, 2024

No description provided.

@LiamConnors LiamConnors requested a review from gvwilson August 30, 2024 14:42
@LiamConnors LiamConnors changed the title Update percy tests Update percy tests to use maps Aug 30, 2024
@LiamConnors LiamConnors requested a review from archmoj August 30, 2024 14:42
@archmoj
Copy link
Copy Markdown
Contributor

archmoj commented Aug 30, 2024

Do we set unused plot config on any of these?

@LiamConnors
Copy link
Copy Markdown
Contributor Author

LiamConnors commented Aug 30, 2024 •
edited
Loading

Do we set unused plot config on any of these?

I don't understand. Do you have an example of what this looks like? And what's the impact of setting/not setting it for these tests?

@archmoj
Copy link
Copy Markdown
Contributor

archmoj commented Aug 30, 2024

Do we set unused plot config on any of these?

I don't understand. Do you have an example of what this looks like? And what's the impact of setting/not setting it for these tests?

I mean if you search inside these tests any of them using set mapbox token?

@LiamConnors
Copy link
Copy Markdown
Contributor Author

LiamConnors commented Aug 30, 2024

Do we set unused plot config on any of these?

I don't understand. Do you have an example of what this looks like? And what's the impact of setting/not setting it for these tests?

I mean if you search inside these tests any of them using set mapbox token?

None of the tests are using that.

@archmoj
Copy link
Copy Markdown
Contributor

archmoj commented Aug 30, 2024

Thanks. Wondering why some tests are failing?

@gvwilson gvwilson added P2 considered for next cycle fix fixes something broken labels Sep 3, 2024
@LiamConnors LiamConnors merged commit 673c19c into master Sep 19, 2024
@LiamConnors LiamConnors deleted the update-percy-tests branch September 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@archmoj archmoj Awaiting requested review from archmoj

1 more reviewer

@gvwilson gvwilson gvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix fixes something broken P2 considered for next cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiamConnors @archmoj @gvwilson