-
-
Notifications
You must be signed in to change notification settings - Fork 2k
docs(colorbar): log/date dtick string forms are not supported on color bars #7991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CAOShurong
wants to merge
4
commits into
plotly:main
Choose a base branch
from
CAOShurong:docs/colorbar-dtick-log-syntax
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−39
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
81bb1cd
fix(sankey): restore node.pad clamp warning broken by d3-sankey v0.12
CAOShurong d7504ab
docs(colorbar): document that log/date dtick string forms are not sup…
CAOShurong 6da4ff3
Revert "fix(sankey): restore node.pad clamp warning broken by d3-sank…
CAOShurong 06654e5
docs: link colorbar draftlog to pull request
CAOShurong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Correct the `colorbar.dtick` (and `coloraxis.colorbar.dtick`) description: the special *log*/*date* string forms (*L<f>*, *D1*, *D2*, *M<n>*) are not supported on color bars - the internal color-bar axis is always linear, so such strings are silently ignored. The attribute now documents that only positive numbers are honored [[#7991](https://github.com/plotly/plotly.js/pull/7991)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -153,10 +153,22 @@ module.exports = overrideAll( | |||||||||||||||||
| description: 'Sets the color of padded area.' | ||||||||||||||||||
| }, | ||||||||||||||||||
| // tick and title properties named and function exactly as in axes | ||||||||||||||||||
| // (except dtick: the colorbar axis is mocked as type *linear*, so the | ||||||||||||||||||
| // special *log*/*date* string forms documented on `dtick` - *L<f>*, | ||||||||||||||||||
| // *D1*, *D2*, *M<n>* - are silently discarded, see #7376) | ||||||||||||||||||
| tickmode: axesAttrs.minor.tickmode, | ||||||||||||||||||
| nticks: axesAttrs.nticks, | ||||||||||||||||||
| tick0: axesAttrs.tick0, | ||||||||||||||||||
| dtick: axesAttrs.dtick, | ||||||||||||||||||
| dtick: extendFlat({}, axesAttrs.dtick, { | ||||||||||||||||||
| description: [ | ||||||||||||||||||
| 'Sets the step in-between ticks on this color bar. Use with `tick0`.', | ||||||||||||||||||
| 'Must be a positive number.', | ||||||||||||||||||
| 'Unlike on x/y axes, the special *log* and *date* string forms', | ||||||||||||||||||
| '(*L<f>*, *D1*, *D2*, *M<n>*) are NOT supported here: this axis is', | ||||||||||||||||||
| 'always linear, so such strings are silently ignored and the step', | ||||||||||||||||||
| 'falls back to its default.' | ||||||||||||||||||
|
Comment on lines
+166
to
+169
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you specify the value rather than mention the default?
Suggested change
|
||||||||||||||||||
| ].join(' ') | ||||||||||||||||||
| }), | ||||||||||||||||||
| tickvals: axesAttrs.tickvals, | ||||||||||||||||||
| ticktext: axesAttrs.ticktext, | ||||||||||||||||||
| ticks: extendFlat({}, axesAttrs.ticks, { dflt: '' }), | ||||||||||||||||||
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please delete this file? We don't need a draftlog for this change.