feat: Switch color processing library#7536
Open
camdecoster wants to merge 37 commits into
Open
Conversation
Contributor
Author
|
I created a couple of PRs (#78 and #81) in a dependency used by color that will add some new features for parsing color strings that would bring it closer to parity with TinyColor. The maintainer recently merged one of these and will (hopefully) be merging the other soon. Once he publishes a new release, I'll be able to use it in plotly.js. |
fc905c7 to
6e83d8a
Compare
6e83d8a to
86e48f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch color processing library from TinyColor to color.
Closes #7523.
Changes
rgb()/rgba()strings with decimal 0–1 fractions are now normalized to integers viaColor.clean()on inputTesting
npm run test-jasmineand verify that all tests passnpm run test-imageand verify that all image-baseline diffs match the regenerated baselines in this PRnpm run schemaproduces no diff againsttest/plot-schema.jsonNotes