Repository navigation
Violin Plot stops the whole of process in specific condition. #6490
Description
plotly version is 5.13.0. When I run this code, jupyter notebook stops and throw this error.
import plotly.express as px
fig = px.violin(x=[0, 0], y=[0.5006312999999999, 0.5006313])
fig.show()
I think there is some problem when inputs has 2 distinct types like float32 and float64. This is quite critical to person who are analyzing the data with violin plot.
I think just convert float64 to float32 in process. But I don't know how to revise the code so I just throw the issue in here.
Activity
alexcjohnson commentedon Feb 17, 2023
Thanks @L0Z1K - I moved this to the plotly.js repo, because the same happens in plain plotly.js https://codepen.io/alexcjohnson/pen/ExejRPQ the page locks up with your data:
L0Z1K commentedon Feb 28, 2023
So is there any plan to fix? or should I contribute by code to handle this issue?
alexcjohnson commentedon Mar 2, 2023
@L0Z1K if you're able to track down the source of this and suggest a fix that would be most welcome!
My hunch is it's this:
plotly.js/src/traces/violin/calc.js
Line 53 in 7427f14
and the
stepis so small that sometimesk++; t += stepdoesn't actually changetbecausestepis on the edge of the floating-point precision of the data values. Maybe it can be fixed by changing tok++, t = span[0] + k * step? Also perhaps change the termination condition tok < n. That said if severaltvalues are identical there may be rendering issues we need to address too.If that fixes it, we'd also need a test - here if indeed the issue is just in the calc step, testing something about
cd[0].densitygvwilson commentedon Jul 4, 2024
Hi - we are trying to tidy up the stale issues and PRs in Plotly's public repositories so that we can focus on things that are still important to our community. Since this one has been sitting for several years, I'm going to close it; if it is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. Thanks for your help - @gvwilson