fix(server): stop stale settlement notifications

[Gigioxx]

Automatic thread settlement refreshes a thread's general update time. Existing completed or failed agent-awareness state then looks fresh enough to queue another mobile notification.

Terminal awareness now keeps the actual turn or provider-session terminal time. Running and waiting states still use the thread update time, so live activity freshness is unchanged. Focused coverage includes settlement cleanup, ready sessions without a materialized turn, and failed sessions.

Validation

• 54 focused shared, server relay, and APNs tests passed
• Shared and server typechecks passed
• Targeted lint and formatting passed
• git diff --check passed

Closes #9057

Made with GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
Narrow change to awareness updatedAt selection for terminal phases only; active-state freshness is unchanged and behavior is covered by focused tests.

Overview
Fixes duplicate or stale mobile notifications when automatic thread settlement bumps thread.updatedAt after work has already finished.

For completed and failed awareness phases, projectThreadAwareness no longer always exposes thread.updatedAt. It now prefers the provider session’s terminal updatedAt (ready/idle for success, error for failure), then latestTurn.completedAt, with fallbacks to session and thread times. Running and waiting phases still use thread.updatedAt so live activity stays current.

Tests separate a later settlement time (NOW) from terminal work time (TERMINAL_AT) and assert updatedAt on interrupted-but-completed turns, ready sessions without a turn row, and failed sessions.

^{Reviewed by Cursor Bugbot for commit 2f9b1f9. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale settlement updatedAt in projectThreadAwareness

The updatedAt field of the returned AgentAwarenessState no longer always uses thread.updatedAt. For completed and failed phases, it now prefers the session's terminal transition time or the latest turn's completedAt.

• Computes terminalSessionAt from session.updatedAt when a completed/failed phase has the matching terminal session status.
• For terminal phases, updatedAt falls back through terminalSessionAt, latestTurn.completedAt, session.updatedAt, then thread.updatedAt.
• Tests in agentAwareness.test.ts now use a TERMINAL_AT constant and assert the new updatedAt behavior.
• Risk: callers that relied on state.updatedAt always matching thread.updatedAt for terminal phases will see a different value.

^{Macroscope summarized 2f9b1f9.}

[macroscopeapp]

Approvability

Verdict: Approved at 2f9b1f9

Macroscope's review found this PR approvable — The PR makes a small, tested correction to use terminal work timestamps rather than later thread metadata when publishing completed or failed awareness states. Its production impact is limited to preventing stale settlement notifications and preserving existing behavior for active states.

^{You can add or adjust custom eligibility rules. Learn more.}

[lnieuwenhuis]

Maintainer verification: the timestamp precedence reads correctly — completed/failed awareness pins terminalSessionAt, then latestTurn.completedAt, then session.updatedAt, so post-finish metadata edits no longer re-fire notifications or tombstone the lock-screen card, while live phases still track thread.updatedAt. Tests pin TERMINAL_AT against a later NOW. One ask: no Check/Test CI appears in this PR's rollup, so it needs a rebase and a CI re-run before merge.