fix(settings): simplify open source license notices - #8970
Merged
juliusmarminge merged 2 commits intoSep 1, 2026
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is an isolated settings UI refactor that preserves existing license loading and filtering while making search and notice expansion more compact. Its runtime impact is limited to local presentation and interaction behavior, with no API, data, security, or infrastructure implications. You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
September 1, 2026 00:15
Dismissing prior approval to re-evaluate be8e961
juliusmarminge
merged commit Sep 1, 2026
b56190e
into
pingdotgg:feat/open-source-licenses
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8962.
This simplifies the open source license page to use the normal settings width, a compact header search, and single-line notice rows with right-aligned metadata.
Verified in the real web client at 1280x800 and 1920x1080, with web typecheck, formatting, targeted lint, and diff checks; lint reports only the two pre-existing request-effect warnings from #8962.
Built with gpt-5.6-sol in the Codex harness through T3 Code.
Note
Simplify open source license notices with collapsible rows and toggleable search
Collapsiblecomponents, allowing only one row open at a time viaopenEntryKeystate inOpenSourceLicensesPanelLicenseHeaderActionwith a toggleable search icon: autofocus on open, blur closes when empty, Escape clears and closesLicenseCountshowing filtered vs total counts in the headerthirdPartyLicenseEntryKeyfor stable list item keysLicenseNoticeRowsignature changed to accept controlledopenstate andonOpenChangecallback; any consumers outsideOpenSourceLicensesPanelwould need updatingMacroscope summarized be8e961.
Note
Low Risk
Settings UI-only changes with no auth, data, or API impact; the main behavioral change is single-row expansion instead of multiple open notices.
Overview
Reworks the open-source licenses settings page to match standard settings layout and a denser list UI.
The page now uses
SettingsSection(“Third-party notices”) with a header action instead of a wide layout, page title, and always-visible search bar. Search is a compact control: count + search icon that expands into anInputGroup(autofocus, Escape clears and closes, blur closes when empty).Each notice is a single-line row with truncated name, version, and right-aligned license/bundle metadata. Rows use shared
Collapsiblecomponents; only one row can be open at a time via parentopenEntryKey. The project source link is an icon button on the row header rather than inside the expanded panel. List keys usethirdPartyLicenseEntryKeyfrom shared.Error and loading states drop extra borders and use smaller typography to align with the simplified section.
Reviewed by Cursor Bugbot for commit be8e961. Bugbot is set up for automated code reviews on this repo. Configure here.