Skip to content

fix(settings): simplify open source license notices - #8970

Merged
juliusmarminge merged 2 commits into
pingdotgg:feat/open-source-licensesfrom
maria-rcks:t3code/improve-open-licenses-ui
Sep 1, 2026
Merged

fix(settings): simplify open source license notices#8970
juliusmarminge merged 2 commits into
pingdotgg:feat/open-source-licensesfrom
maria-rcks:t3code/improve-open-licenses-ui

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Stacked on #8962.

This simplifies the open source license page to use the normal settings width, a compact header search, and single-line notice rows with right-aligned metadata.

Verified in the real web client at 1280x800 and 1920x1080, with web typecheck, formatting, targeted lint, and diff checks; lint reports only the two pre-existing request-effect warnings from #8962.

Built with gpt-5.6-sol in the Codex harness through T3 Code.

Note

Simplify open source license notices with collapsible rows and toggleable search

  • Replaces the license row expand/collapse with externally controlled Collapsible components, allowing only one row open at a time via openEntryKey state in OpenSourceLicensesPanel
  • Adds LicenseHeaderAction with a toggleable search icon: autofocus on open, blur closes when empty, Escape clears and closes
  • Adds LicenseCount showing filtered vs total counts in the header
  • Moves the project source link from inside the expanded panel to a trailing icon button in the row header
  • Uses thirdPartyLicenseEntryKey for stable list item keys
  • Risk: LicenseNoticeRow signature changed to accept controlled open state and onOpenChange callback; any consumers outside OpenSourceLicensesPanel would need updating

Macroscope summarized be8e961.


Note

Low Risk
Settings UI-only changes with no auth, data, or API impact; the main behavioral change is single-row expansion instead of multiple open notices.

Overview
Reworks the open-source licenses settings page to match standard settings layout and a denser list UI.

The page now uses SettingsSection (“Third-party notices”) with a header action instead of a wide layout, page title, and always-visible search bar. Search is a compact control: count + search icon that expands into an InputGroup (autofocus, Escape clears and closes, blur closes when empty).

Each notice is a single-line row with truncated name, version, and right-aligned license/bundle metadata. Rows use shared Collapsible components; only one row can be open at a time via parent openEntryKey. The project source link is an icon button on the row header rather than inside the expanded panel. List keys use thirdPartyLicenseEntryKey from shared.

Error and loading states drop extra borders and use smaller typography to align with the simplified section.

Reviewed by Cursor Bugbot for commit be8e961. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 31, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 1, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at be8e961

Macroscope's review found this PR approvable — This is an isolated settings UI refactor that preserves existing license loading and filtering while making search and notice expansion more compact. Its runtime impact is limited to local presentation and interaction behavior, with no API, data, security, or infrastructure implications.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 1, 2026 00:15

Dismissing prior approval to re-evaluate be8e961

@juliusmarminge
juliusmarminge merged commit b56190e into pingdotgg:feat/open-source-licenses Sep 1, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants