fix(web): tolerate external project script ids in keybinding commands - #7961
Closed
xuzhaorui wants to merge 1 commit into
Closed
fix(web): tolerate external project script ids in keybinding commands#7961xuzhaorui wants to merge 1 commit into
xuzhaorui wants to merge 1 commit into
Conversation
The server accepts any non-empty trimmed string as a ProjectScript id, but the client's SCRIPT_RUN_COMMAND_PATTERN only allowed lowercase slugs of up to 24 characters. An id dispatched over the API (e.g. a UUID) made commandForProjectScript throw during render, crashing every thread view and the project settings panel with no way to repair from the UI. Relax the pattern's middle segment to TrimmedNonEmptyString, matching the server-side constraint. UI-generated ids are still slugs via nextProjectScriptId, so nothing changes for normal usage; existing keybinding rules keep decoding. Fixes pingdotgg#7851 Worked on by ox-alpha via the pi coding agent harness.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:unvouched
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 27, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 28, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 28, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 28, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 28, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 28, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 29, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 29, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 29, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 30, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Aug 31, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 1, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 2, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 2, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 2, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 2, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 2, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 2, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 3, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 3, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 3, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 3, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 3, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 5, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 5, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 5, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 5, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 5, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
lastobelus
added a commit
to lastobelus/lastCode
that referenced
this pull request
Sep 5, 2026
…#112) ## Summary - import the maintainer-preferred fix from pingdotgg#7961 at pinned head `6be823df41b105ddee33677f0b72aa4f5ad1c868` - accept every canonical non-empty project-script ID when constructing dynamic keybinding commands, matching the existing `ProjectScript` contract - keep UI-generated IDs as the existing lowercase slugs while allowing externally supplied and already-saved IDs - reject whitespace-padded dynamic commands instead of accepting shortcuts that cannot match normalized saved IDs ## Incident A saved htulo action used ID `build-intel-package-macos` (25 characters). The renderer mapped that valid project script through a 24-character template-literal schema during render, throwing `Expected a string matching template literal parts` in both thread controls and Project Settings. No persisted project data was changed or migrated. ## Validation - 24 focused tests across the dynamic-command contract, project-script helpers, and project-script keybinding decoder - contracts and web typechecks - focused formatting and lint - committed-range `git diff --check` - disposable matched fixture with the exact 25-character action ID rendered in chat - locally installed recovery build opened the real htulo thread and rendered **Build Intel package (macOS)** in Project Settings ## Provenance - upstream issue: pingdotgg#7851 - upstream PR: pingdotgg#7961 - exact upstream commit preserved by `cherry-pick -x` Refs #103 --------- Co-authored-by: xuzhaorui <119386408+xuzhaorui@users.noreply.github.com>
Member
|
Superseded by #10019 — same bug (invalid script IDs crashing threads via commandForProjectScript). Main now validates new IDs server-side and returns null for unsupported commands instead of relaxing the keybinding schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The server accepts any non-empty trimmed string as a
ProjectScript.id, but the client'sSCRIPT_RUN_COMMAND_PATTERNonly allowed lowercase slugs of up to 24 characters. An id dispatched over the API (e.g. a UUID) madecommandForProjectScriptthrow during render, crashing every thread view and the project settings panel with no way to repair from the UI.Fix
Relax the pattern's middle segment to
TrimmedNonEmptyString, matching the server-side constraint. UI-generated ids are still slugs vianextProjectScriptId, so nothing changes for normal usage; existing keybinding rules keep decoding.Fixes #7851
Validation
vp test run packages/contracts/src/keybindings.test.ts apps/web/src/projectScripts.test.ts— 19 tests passed (includes new UUID round-trip cases)pnpm --filter @t3tools/contracts typecheckpnpm --filter @t3tools/web typecheckvp fmt --check,vp lint,git diff --checkWorked on by ox-alpha via the pi coding agent harness.
Note
Accept external script IDs in
script.<id>.runkeybinding commandsReplaces the constrained
NonEmptyStringschema for the middle segment ofkeybindings.SCRIPT_RUN_COMMAND_PATTERNwithTrimmedNonEmptyString, so external IDs like UUIDs are accepted. Tests in keybindings.test.ts and projectScripts.test.ts are updated to cover UUID-style IDs and confirm that empty IDs remain invalid./^[a-z0-9][a-z0-9-]*$/pattern and max-length checks on the script ID segment; any trimmed non-empty string is now valid.Macroscope summarized 6be823d.