Skip to content

fix(marketing): detect CPU arch for macOS download button instead of hardcoding arm64 #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shalin-Shah-2002 wants to merge 2 commits into from
Closed

fix(marketing): detect CPU arch for macOS download button instead of hardcoding arm64 #4532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e75af
fix(marketing): detect CPU arch for macOS download button instead of …
Shalin-Shah-2002 Jul 25, 2026
1f346d7
fix(marketing): remove unreliable UA-based Intel fallback — all macOS…
Shalin-Shah-2002 Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions apps/marketing/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,22 @@ const mobileEndorsementRows = [

type Platform = { os: "mac" | "win" | "linux"; label: string; arch?: string };

function detectPlatform(): Platform | null {
async function detectPlatform(): Promise<Platform | null> {
const ua = navigator.userAgent;
if (/Win/i.test(ua)) return { os: "win", label: "Download for Windows" };
if (/Mac/i.test(ua)) {
return { os: "mac", label: "Download for macOS", arch: "arm64" };
let arch = "arm64";
try {
const uad = (navigator as { userAgentData?: { getHighEntropyValues: (hints: string[]) => Promise<{ architecture?: string }> } }).userAgentData;
if (uad?.getHighEntropyValues) {
const values = await uad.getHighEntropyValues(["architecture"]);
if (values.architecture === "x86") arch = "x64";
}
} catch {
// UA-based fallback is unreliable — all macOS UAs report "Intel Mac OS X",
// even on Apple Silicon. Default to arm64 (majority of modern Macs).
}
return { os: "mac", label: "Download for macOS", arch };
}
if (/Linux/i.test(ua)) return { os: "linux", label: "Download for Linux" };
return null;
Expand Down Expand Up @@ -415,7 +426,7 @@ const mobileEndorsementRows = [
const ctaLabel = document.getElementById("cta-download-label");
const kbd = document.getElementById("pr-button-kbd");

const platform = detectPlatform();
const platform = await detectPlatform();
if (!platform) return;
document.documentElement.dataset.platform = platform.os;
if (label) label.textContent = platform.label;
Expand Down
Loading