Stabilize sidebar settling animations - #4280
Conversation
- Key card and slim rows by variant to prevent cross-row FLIP artifacts - Render the Settled divider as a stable standalone list item
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This PR restructures how the 'Settled' divider is rendered in the sidebar to improve animation stability when threads settle. The visual output is unchanged - only the DOM structure and React keys are modified to prevent animation artifacts. Low-risk UI fix with no business logic changes. You can customize Macroscope's approvability policy. Learn more. |
Summary
Testing
Note
Low Risk
Sidebar-only list rendering and keys; no settlement API or routing changes.
Overview
Improves Sidebar v2 behavior when a thread moves from an active card into the settled slim tail so
auto-animateno longer looks like one row sliding through translucent neighbors.Row React keys now include the variant (
cardvsslim), so settling unmounts the card and mounts the slim row at the settled position instead of morphing a single list item. The Settled label/divider is rendered as its own keyed<li>at the active→settled boundary (viaflatMap), not inside the first settled row viashowSettledGap.Reviewed by Cursor Bugbot for commit 46494ca. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Stabilize sidebar settled-section divider as a standalone list item
SidebarV2Rowand into the parent list as its own<li>element, inserted immediately before the first settled row.maptoflatMapin SidebarV2.tsx to support injecting the divider element inline.:cardor:slim), forcing a remount when a thread transitions between card and slim variants, which stabilizes transition animations.Macroscope summarized 46494ca.