-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Refine archive management UX across web and mobile #3552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
106 commits
Select commit
Hold shift + click to select a range
cacf444
Refine archived settings panel UX
Quicksaver 57a1e76
Move archived project actions into context menu
Quicksaver 67a0477
Add archive thread search and ranked filtering
Quicksaver da19562
Scope archive bulk actions to visible threads
Quicksaver 5d9ac5a
Fix archive project bulk actions during search
Quicksaver d8cb38b
Scope archive bulk actions to visible rows
Quicksaver 1b02962
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 74fcff2
Respect archive delete confirmation setting
Quicksaver 6167a3d
Clarify archived bulk failure toasts
Quicksaver 9653b5b
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 5455c7e
Port archive settings review fix
Quicksaver b6ad57b
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver e493576
Address archive settings review follow-ups
Quicksaver 8405c06
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 7d9e19f
Refactor archived settings logic
Quicksaver 8fb00f4
Fix archived project bulk action errors
Quicksaver a5b1b97
Fix archived settings review issues
Quicksaver 0c08df9
Fix archived confirmation fallback
Quicksaver a579f7e
Fix archived project grouping keys
Quicksaver 5ff0c25
Fix archived project UI keys
Quicksaver 5d8b2f3
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver b07ae41
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 6ae2079
Move archived settings into a dedicated panel
Quicksaver 39e2452
Fix archived project action access
Quicksaver 19e1ffa
Align archived thread rows with headers
Quicksaver 9ccfdce
Fix archived settings review issues
Quicksaver 3c509f3
Fix archive action confirmation fallback
Quicksaver 0d07f3a
Handle archive bulk action exceptions
Quicksaver 10632e1
Fetch archive settings across all environments
Quicksaver 26eea31
Clarify filtered archive bulk menu actions
Quicksaver 5c7e395
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver c8e2721
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver c7dacda
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 69785d4
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 26733f7
Merge remote-tracking branch 'refs/remotes/upstream/main' into split/…
Quicksaver e27d68a
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver ee7557c
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 0cfc5ee
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver d6355b5
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 9d1de46
Add archive settings branch details
Quicksaver 7e60c51
Remove unrelated archive behavior claim
Quicksaver d13a277
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 7c4995d
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver f5e2450
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 89256c8
Expand native archived threads management
Quicksaver 5fe8242
Document native archive settings UX behavior
Quicksaver 4c4555c
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver d8f7c59
Configure pnpm virtual store and Effect Vitest peers
Quicksaver 5629fc9
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 556df7c
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 0babd24
Fix archive sorting and failure feedback
Quicksaver 7aa53f0
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver bf242fd
Fix archive review regressions
Quicksaver 7e257a4
Surface mobile archive bulk failure details
Quicksaver 6f38d10
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver fd6316d
Show environment labels in archived project headers
Quicksaver 8463f78
Add multi-environment archive label coverage
Quicksaver 30e519e
Distinguish skipped archive actions
Quicksaver 2485e27
Preserve archive search ranking tiers
Quicksaver 2dd5fe6
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 355171e
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver eceaec8
Test merged mobile thread action contract
Quicksaver cb1b9ed
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 64667ad
Adapt archive UX to current upstream
Quicksaver 92e2c41
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver ad79c99
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 6937933
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 6dc2e6a
Test archived-only project deletion safeguard
Quicksaver b23d02c
Strengthen archived project deletion test
Quicksaver 1f4de96
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 19d8ffb
Prevent overlapping web archive mutations
Quicksaver 565d10a
Refine web archive action feedback
Quicksaver 53dd9a0
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver d465583
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 293c010
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver ab00425
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver e42c5a8
Test snoozed threads stay out of archives
Quicksaver bfde736
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 15dc499
Fix mobile archive action reservations
Quicksaver 6ba8c8f
Preserve archive action and search state
Quicksaver 9235306
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 8fe838a
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 81483c3
Make mobile thread action keys collision-safe
Quicksaver 2eaa900
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 3441204
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver c403a81
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
Quicksaver 963f2cb
Merge commit '96398e3775fc6c74525e4a211e75e580c6cf4225' into split/ar…
Quicksaver cf2996a
Merge commit '32843c2551bd5832d436ef46bff5ab1198cdc39c' into split/ar…
Quicksaver c281ad8
Merge commit '887dd6e455bb969c1a0c9659a6bdf2baceac030d' into split/ar…
79e5efb
Fix ascending archive project ordering
80ffdfb
Avoid spreading archive project timestamps
6dabe11
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
8eeb294
docs: document archive workflows
e18c872
docs: track archive documentation surface
a95f995
Merge commit '2919147c80e4daae326a25f870a1c7b19cd16f42' into split/ar…
f0b32c3
Merge commit '8650f05f95ac9f19254de679fdf4b380c37d7b94' into split/ar…
978a077
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
ca09d03
Refactor shared native settings contract
46db3ae
Document shared native settings contract
b27b142
Remove unused waitlist alias target
d39a858
Merge commit '1b4830ff06bf80e505dbf669deef189af85f77d7' into split/ar…
e2c15bc
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
e699a4c
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
495783b
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
90745da
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
3d969ba
Merge remote-tracking branch 'upstream/main' into split/archive-setti…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Archive Settings UX | ||
|
|
||
| The settings Archive panel uses a dense layout so large archives remain scannable. The native mobile Archived Threads screen mirrors the same information hierarchy and behavior with mobile-native project sections, swipe actions, long-press menus, and header controls. | ||
|
|
||
| Expected behavior: | ||
|
|
||
| - Archived conversations are grouped by project, and each project group is collapsed by default. | ||
| - The Archive panel fetches archived thread snapshots from all configured environments, not only environments that currently have active projects, so archived-only workspaces remain visible, while active rows returned in those snapshots remain excluded from archive content and empty-state counts. | ||
| - Web project headers show environment labels whenever multiple environments are configured and keep a sole remote environment labeled, while a sole primary environment remains implicit. Native project sections show environment labels and the header controls can filter the archive to all environments or one configured environment. | ||
| - Native Settings exposes `Archived Threads` in both local-only and T3 Connect-configured modes through a shared `General`, `Appearance`, `Beta`, `Archive`, and `App` tail, preserving that order while each mode keeps its own account and configuration controls. The native settings contract owns the `SettingsArchive` route name, link, and title plus the legacy `SettingsWaitlist` alias metadata, while the native stack keeps that distinct alias pointed at `SettingsAuth`. | ||
| - The page includes a search box that filters archived thread titles across all projects case-insensitively. Multi-word searches match any term, rank exact phrase matches first, rank titles matching every term ahead of partial term matches, and auto-open matching project groups while search is active. Native incremental search updates the existing list without remounting it for every keystroke, preserving scroll position and transient row state. | ||
| - Expanded project headers include sortable `Archived` and `Created` columns; clicking either header toggles ascending/descending order for the conversations inside each group, with `Archived` descending as the default. | ||
| - Native project-section ordering follows the selected archive sort field and direction. Invalid archived timestamps fall back to the conversation's created timestamp for sorting and display on both surfaces. | ||
| - Native row and bulk actions share collision-safe per-thread reservations and action-executor identity keys, reserve bulk targets before confirmation, expose busy state only after confirmation, disable overlapping swipe/menu controls while reserved, and distinguish rows skipped because the same thread action is already in progress from commands that actually fail. | ||
| - Web row and project actions reserve collision-safe per-thread locks before confirmation, expose busy state only for the threads owned by actions that have started after confirmation, disable overlapping controls while mutations run, give explicit feedback for rejected duplicates, and refresh archived snapshots once after bulk attempts instead of between concurrent mutations. | ||
| - Conversation rows show only the relative archived and created ages inline with the title by default. On web row hover or keyboard focus, those age labels fade out and icon-only unarchive/delete actions appear as a right-side overlay with tooltips, matching the sidebar and source-control list-row action pattern. Native rows keep both age columns visible and expose the same actions through swipe gestures and the standard long-press context menu. | ||
| - Archived conversations can be deleted directly from the Archive panel without unarchiving first. Web delete actions respect the shared `confirmThreadDelete` client setting, while native keeps its standard guarded delete flow. | ||
| - Project group context menus expose `unarchive all` and `delete all` actions. While search is active, those bulk actions apply to the visible matching archived conversations and use matching-specific menu labels; otherwise they apply to all archived conversations in the project. Delete confirmations respect `confirmThreadDelete` on web and remain explicitly guarded on native; unarchive bulk actions remain guarded on both surfaces, and partial failures surface as not-fully-completed feedback instead of implying every archived thread failed. | ||
| - Archive grouping, search ranking, sort state, and project bulk-action concurrency live in `apps/web/src/components/settings/SettingsPanels.logic.ts` on web and `apps/mobile/src/features/archive/archivedThreadList.ts` on native so the dense Archive behavior stays covered without growing the React components. Project groups expose and reuse collision-safe keys so project ids containing separator characters do not collapse expansion state or React row identity. Bulk actions stop scheduling new work after thrown failures, wait for active workers to settle, preserve the completed success/failure/skipped outcome counts, show incomplete-operation feedback, and surface the underlying exception messages instead of only a generic aggregate error. The Archive surfaces refresh archived threads after bulk unarchive/delete attempts even when the action runner throws. | ||
| - The user guide documents Archive as a reversible thread-lifecycle action, covers the web, desktop, and mobile controls and safeguards, and explains that search scopes project bulk actions to visible matches. The documentation index links the guide, and the encyclopedia defines the Archive term separately from permanent deletion. | ||
|
|
||
| Primary files: | ||
|
|
||
| - `apps/web/src/components/settings/ArchiveSettings.tsx` | ||
| - `apps/web/src/components/settings/SettingsPanels.tsx` | ||
| - `apps/web/src/components/settings/SettingsPanels.logic.ts` | ||
| - `apps/mobile/src/Stack.tsx` | ||
| - `apps/mobile/src/features/settings/SettingsRouteScreen.tsx` | ||
| - `apps/mobile/src/features/settings/settingsContract.ts` | ||
| - `apps/mobile/src/features/settings/settingsContract.test.ts` | ||
| - `apps/mobile/src/features/archive/ArchivedThreadsRouteScreen.tsx` | ||
| - `apps/mobile/src/features/archive/ArchivedThreadsScreen.tsx` | ||
| - `apps/mobile/src/features/archive/archivedThreadList.ts` | ||
| - `docs/user/archive.md` | ||
| - `docs/reference/encyclopedia.md` | ||
| - `docs/README.md` | ||
|
|
||
| ## Development Ports | ||
|
|
||
| - Web: `5734` | ||
| - Server/WebSocket: `13774` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.