You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(web): minimap next-turn test no longer flakes after a resize - #33964
MessagesTimeline.browser.test.tsx > disables the minimap's next turn button at the bottom of the thread (added in #33038) fails on PR CI with expected 0 to be greater than 500. It hit 5 unrelated PRs in the 2 hours after it landed. Locally it fails every time when the whole file runs.
The test moves 30px off the bottom, then returns to the bottom and shrinks the viewport. It expects the bottom to move away. But a 30px nudge still counts as "at end" for LegendList, so Legend keeps its initial end anchor. On the resize, Legend's preserved end-anchor correction calls scrollTo back to the bottom. This is separate from maintainScrollAtEnd, so liveFollowEnabled={false} does not stop it.
Change
Test only. Before the detached-bottom checks, scroll to the top and wait for the first minimap strip to be in view. That releases Legend's anchor. The 30px check and both detached cases (shrink, footer growth) stay as they were. Product behavior does not change. Re-pinning to the end on a resize while the initial anchor is held is correct.
Scope and approval
Focused fix for a flaky test that blocks unrelated PRs. No product code changes.
Verification
Old code: fails 3/3 running the full file, and 1/1 with -t "settles when equally|keeps the first and last|disables the minimap".
With the fix: 3/3 pass both ways.
A scrollTo trap on the viewport recorded one Legend re-pin after the resize on the old code (from schedulePreservedEndAnchorCorrection), and zero with the fix.
vp run check:changed passes.
Reviewed with sol-loop: 1 pass with GPT-6.1 Sol. Sol verdict: approved
… the resize
The test nudged the viewport 30px off the bottom, which still counts as the
end for LegendList, so the initial end anchor stayed armed. When the test
then shrank the viewport, Legend re-pinned it to the bottom and the
"bottom moves away" assertion saw 0. Scroll to the top first so Legend
releases the anchor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Macroscope's review found this PR approvable — The reported change is a three-line test-stability adjustment confined to repository-ignored paths. The supplied scope and context indicate no material product or operational impact requiring human judgment.
Notes:
No code objects were reviewed. Approvability was decided on eligibility alone.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
The minimap browser test now scrolls the viewport to the top after moving away from the thread’s bottom. It waits for the first minimap strip to be marked in view.
Changes: Minimap visibility test
Layer / File(s)
Summary
Top scroll visibility assertion apps/web/src/components/chat/MessagesTimeline.browser.test.tsx
The test scrolls the viewport to the top and waits for the first minimap strip to be marked in view.
pingdotgg/t3code#23942: Changes how the minimap derives its current index and updates minimap state after viewport changes.
pingdotgg/t3code#23780: Changes LegendList size-change anchoring and end maintenance, which concerns scroll-position behavior.
Suggested reviewers:juliusmarminge, macroscopeapp
Merge Risk: Minimal · up to 9cbc9
The test change preserves the resize and footer-growth checks. No merge-blocking issue was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly identifies the minimap test’s resize-related flake, which is the main change.
Description check
The description covers the problem, test-only change, focused scope, and specific verification results. UI screenshots do not apply because the change does not affect the product UI.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Problem
MessagesTimeline.browser.test.tsx > disables the minimap's next turn button at the bottom of the thread(added in #33038) fails on PR CI withexpected 0 to be greater than 500. It hit 5 unrelated PRs in the 2 hours after it landed. Locally it fails every time when the whole file runs.The test moves 30px off the bottom, then returns to the bottom and shrinks the viewport. It expects the bottom to move away. But a 30px nudge still counts as "at end" for LegendList, so Legend keeps its initial end anchor. On the resize, Legend's preserved end-anchor correction calls
scrollToback to the bottom. This is separate frommaintainScrollAtEnd, soliveFollowEnabled={false}does not stop it.Change
Test only. Before the detached-bottom checks, scroll to the top and wait for the first minimap strip to be in view. That releases Legend's anchor. The 30px check and both detached cases (shrink, footer growth) stay as they were. Product behavior does not change. Re-pinning to the end on a resize while the initial anchor is held is correct.
Scope and approval
Focused fix for a flaky test that blocks unrelated PRs. No product code changes.
Verification
-t "settles when equally|keeps the first and last|disables the minimap".scrollTotrap on the viewport recorded one Legend re-pin after the resize on the old code (fromschedulePreservedEndAnchorCorrection), and zero with the fix.vp run check:changedpasses.Reviewed with sol-loop: 1 pass with GPT-6.1 Sol. Sol verdict: approved
Made by Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code