Repository navigation
test: remove redundant short-string truncation test - #33867
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This removes a redundant truncation test within the repository’s ignored scope. No production behavior, product defaults, or diagnostic-suppression directives are changed. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Nov 10, 2026
**v0.1.9-nightly.20261110.4478** · 25 changes from 7 contributors - **Touchscreen panel resizing.** Drag panel resize handles on a touchscreen without the browser interrupting the gesture. - **Faster long threads.** Long threads open faster without reading their entire history. - **Browser tab actions.** New desktop Browser tabs can respond to waits, clicks, and snapshots. - **Delegated task completions.** Removing one queued completion message no longer prevents sibling task completions from arriving. - **Cursor steering.** Steering a Cursor run now preserves the original request. ### Plus 19 more bug fixes and performance improvements. <details> <summary>Full changelog</summary> ## What's Changed * fix(server): one finished turn looks up its branch's pull request once by @juliusmarminge in pingdotgg/t3code#33752 * fix(mobile): Android Files sheet scrolls its tree instead of dragging the sheet by @RadekManak in pingdotgg/t3code#33223 * fix(web): prompt suggestions show after a steered turn by @thelogicmatrix in pingdotgg/t3code#33706 * fix(server): usage prices Claude Mythos 5.2 from its Bedrock rate by @juliusmarminge in pingdotgg/t3code#33721 * fix(server): Claude turns whose CLI exits before its first frame fail instead of running forever by @juliusmarminge in pingdotgg/t3code#33008 * fix(web): panel resize handles follow touch drags by @juliusmarminge in pingdotgg/t3code#33066 * fix(server): signed-out Claude instances with their own config dir name it in the sign-in hint by @juliusmarminge in pingdotgg/t3code#32951 * perf(server): opening a long thread reads from its latest segments, not its whole history by @t3dotgg in pingdotgg/t3code#33305 * fix(server): repos without a remote no longer record failed spans on status refresh by @ferhtgoldaraz in pingdotgg/t3code#32905 * fix(mobile): missing files in previews name the checked path instead of asking to reconnect by @juliusmarminge in pingdotgg/t3code#32994 * fix(server): a restart that misses its turn starts as a new turn by @juliusmarminge in pingdotgg/t3code#32899 * fix(desktop): new browser tabs no longer lose waits, clicks and snapshots for good by @juliusmarminge in pingdotgg/t3code#32861 * fix(web): Go to source on a side chat quote keeps you on its parent thread by @juliusmarminge in pingdotgg/t3code#33160 * fix(server): removing a queued completion message keeps its siblings' wakes by @juliusmarminge in pingdotgg/t3code#32815 * fix(server): dev database seed drops active pull request watches by @juliusmarminge in pingdotgg/t3code#32744 * fix(server): capture iOS screenshots on Xcode 26's simctl by @shivamhwp in pingdotgg/t3code#28353 * fix(mobile): medium Android windows keep the rail's room and the sidebar's place by @dongxingong in pingdotgg/t3code#33021 * fix(web): notify when a new request replaces the pending one in a run by @juliusmarminge in pingdotgg/t3code#32719 * fix(server): Codex first-request usage limits keep their reset time by @shivamhwp in pingdotgg/t3code#27791 * fix(web): minimap next turn is disabled at the bottom of a thread by @juliusmarminge in pingdotgg/t3code#33038 * fix(cursor): a steer keeps the prompt it interrupted by @juliusmarminge in pingdotgg/t3code#32583 * test: remove redundant short-string truncation test by @t3-code-bot[bot] in pingdotgg/t3code#33867 * fix(pi): Pi models whose provider ID contains a slash can be selected by @juliusmarminge in pingdotgg/t3code#32585 * perf(server): MCP tool calls no longer read the caller's whole thread by @t3dotgg in pingdotgg/t3code#33295 * fix(ssh): concurrent launches on one remote home share one server by @juliusmarminge in pingdotgg/t3code#32587 ## New Contributors * @RadekManak made their first contribution in pingdotgg/t3code#33223 * @thelogicmatrix made their first contribution in pingdotgg/t3code#33706 * @ferhtgoldaraz made their first contribution in pingdotgg/t3code#32905 * @dongxingong made their first contribution in pingdotgg/t3code#33021 **Full Changelog**: pingdotgg/t3code@v0.1.9-nightly.20261110.4465...v0.1.9-nightly.20261110.4478 </details> Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.9-nightly.20261110.4478
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
remove the complete
leaves short text alonetest frompackages/shared/src/String.test.ts. it repeats the same no-truncation branch already checked by stronger retained cases. no production changes.removal evidence
truncate("hello", 50) === "hello"truncate("👍👍👍", 5) === "👍👍👍"covers a strictly shorter input, including unicode code-point handling;truncate(" hello ", 5) === "hello"covers the inclusive boundary and trimmingString.ts:2-5trims, builds code points, and returns the trimmed input whencharacters.length <= maxLengththis is not the default-argument test: the removed call explicitly supplies 50. the retained over-limit emoji case still checks actual truncation. the deleted test adds no distinct branch, edge case, integration boundary, or production path.
broader audit included mobile/web stack navigation, terminal synchronization, shared/re-exported endpoint and project helpers, codex auth callbacks, diff paging/highlighting, composer layout, oauth scopes, and cached-test tooling. similar-looking stack tests exercise separate implementations; callback and re-export tests without canonical duplicates remain. no entire file was proven valueless, so none was removed merely to enlarge the diff.
verification
origin/mainat0a9abddaee00on a new branch.vp test run packages/shared/src/String.test.ts: before 3 passed; after 2 passed. both initial runs reported unrelated missing workspace-package pre-transform errors despite exiting 0.vp install --frozen-lockfile(exit 0).vp run check:changed: final exit 0. formatting, lint, both knip passes, affected/dependent typechecks (35 packages), and selected tests (2 files, 4 tests) passed. typecheck emitted non-failing schema-brand suggestions.check:changedfailed on stale dependencies, missingeffect-tsgo, and license-generation errors; all resolved after installation and the final run above passed.git diff --check: passed. reviewed the full diff: only one complete test and its separator removed, no secrets or production edits.scheduled useless-test audit automation; bot-only authorship, no human co-author.
model: gpt-6.1-sol. harness: hermes agent.