Repository navigation
ci(mobile): keep the Android store AAB as a workflow artifact - #33674
Merged
Merged
Conversation
eas submit --path doesn't keep its archive on EAS, so Blacksmith store builds were only downloadable from Google Play. Keep the AAB for 14 days so a build can be sideloaded or inspected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Keeps the existing Android store bundle as a downloadable workflow artifact for 14 days. The upload targets only the AAB and leaves application behavior and Google Play submission configuration unchanged. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since https://git.cafe/pingdotgg/t3code/pulls/33565, Android store builds run
eas build --localon Blacksmith and upload witheas submit --path. A path-based submission doesn't keep its archive on EAS: the first one (run 42744302493) has an emptyarchiveUrl, while EAS-built submissions link their.aab. The runner is discarded afterwards, so the only copy of a store build is the one on Google Play. We can't sideload or inspect a build.Change
After Build, the Android store-build job uploads
$RUNNER_TEMP/t3code.aabas the workflow artifactandroid-store-aab-<run id>-<attempt>, kept for 14 days. It fails if the file is missing. It's skipped when the build is skipped. The iOS opt-in job is unchanged.Verification
Workflow-only. The next Android store build will show the artifact on its run page.
🤖 Generated with Claude Code