Skip to content

ci(mobile): keep the Android store AAB as a workflow artifact - #33674

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/keep-android-store-aab
Nov 10, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3code/keep-android-store-aab

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

Problem

Since https://git.cafe/pingdotgg/t3code/pulls/33565, Android store builds run eas build --local on Blacksmith and upload with eas submit --path. A path-based submission doesn't keep its archive on EAS: the first one (run 42744302493) has an empty archiveUrl, while EAS-built submissions link their .aab. The runner is discarded afterwards, so the only copy of a store build is the one on Google Play. We can't sideload or inspect a build.

Change

After Build, the Android store-build job uploads $RUNNER_TEMP/t3code.aab as the workflow artifact android-store-aab-<run id>-<attempt>, kept for 14 days. It fails if the file is missing. It's skipped when the build is skipped. The iOS opt-in job is unchanged.

Verification

Workflow-only. The next Android store build will show the artifact on its run page.

🤖 Generated with Claude Code

eas submit --path doesn't keep its archive on EAS, so Blacksmith store builds
were only downloadable from Google Play. Keep the AAB for 14 days so a build can
be sideloaded or inspected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Nov 10, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8c43c40

Macroscope's review found this PR approvable — Keeps the existing Android store bundle as a downloadable workflow artifact for 14 days. The upload targets only the AAB and leaves application behavior and Google Play submission configuration unchanged.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 73fb49d into main Nov 10, 2026
29 of 30 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/keep-android-store-aab branch November 10, 2026 03:06
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Baseline: 8226715 · PR result: 8c43c40 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant