Skip to content

fix(ci): store-build checkouts drop credentials without submodule cleanup #33664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Nov 10, 2026
+30 −4
Merged

fix(ci): store-build checkouts drop credentials without submodule cleanup #33664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions .github/workflows/mobile-eas-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,8 +504,21 @@ jobs:
with:
ref: ${{ needs.production.outputs.android_sha }}
fetch-depth: 0
# Dependency scripts and the build run in this job; only Record build gets a token.
persist-credentials: false

# Dependency scripts and the build run in this job; only Record build gets a token.
# persist-credentials: false would clean up via `git submodule foreach`, which fails on .repos gitlinks.
- name: Drop checkout credentials
run: |
git config --local --unset-all http.https://github.com/.extraheader || true
{ git config --local --name-only --get-regexp '^includeif\.' || true; } | while read -r key; do
path=$(git config --local --get "$key")
git config --local --unset-all "$key"
case "$path" in "$RUNNER_TEMP"/*) rm -f "$path" ;; esac
done
if git config --local --get-regexp '^(http\..*\.extraheader|includeif\.)'; then
echo "::error::Checkout credentials are still configured"
exit 1
fi

# A queued run can follow a build of the same fingerprint; manual runs always build.
- id: record
Expand Down Expand Up @@ -687,8 +700,21 @@ jobs:
with:
ref: ${{ needs.production.outputs.ios_sha }}
fetch-depth: 0
# Dependency scripts and the build run in this job; only Record build gets a token.
persist-credentials: false

# Dependency scripts and the build run in this job; only Record build gets a token.
# persist-credentials: false would clean up via `git submodule foreach`, which fails on .repos gitlinks.
- name: Drop checkout credentials
run: |
git config --local --unset-all http.https://github.com/.extraheader || true
{ git config --local --name-only --get-regexp '^includeif\.' || true; } | while read -r key; do
path=$(git config --local --get "$key")
git config --local --unset-all "$key"
case "$path" in "$RUNNER_TEMP"/*) rm -f "$path" ;; esac
done
if git config --local --get-regexp '^(http\..*\.extraheader|includeif\.)'; then
echo "::error::Checkout credentials are still configured"
exit 1
fi

# A queued run can follow a build of the same fingerprint; manual runs always build.
- id: record
Expand Down
Loading