Repository navigation
fix(desktop): close focused DevTools with Cmd+W - #33518
Merged
Merged
Conversation
github-actions
Bot
added
the
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Cmd/Ctrl+W now closes focused DevTools while preserving the app’s tab and terminal shortcut handling. The change is confined to local desktop interactions and presents no obvious material risk requiring human judgment. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Pipyakas
pushed a commit
to Pipyakas/t3code
that referenced
this pull request
Nov 9, 2026
Add a native Cmd/Ctrl+W shortcut that closes focused DevTools while retaining renderer tab and terminal shortcuts and repeated-key protection. Validation: 31 focused tests, check:changed, and CI passed. Electron runtime checks verified the close handler; automated native keypress verification remains unconfirmed. Model: GPT 6.1 Sol. Harness: Codex. (cherry picked from commit 206a8e6)
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Nov 9, 2026
**v0.1.8-nightly.20261109.4433** · 13 changes from 4 contributors - **Claude Fable 5.2.** Choose Claude Fable 5.2 from the model picker. - **Faster model discovery.** Opening the model picker checks for new models and surfaces the Claude Code update needed to use them. ### Plus 8 more bug fixes. <details> <summary>Full changelog</summary> ## What's Changed * fix(mobile): the thread feed re-wraps once when an iOS column resizes by @juliusmarminge in pingdotgg/t3code#33459 * fix(speech): match reference benchmarks to transcription hardware by @UtkarshUsername in pingdotgg/t3code#31956 * feat(models): add Claude Fable 5.2 by @t3dotgg in pingdotgg/t3code#33500 * fix(mobile): the chat inset resets after the keyboard closes while frozen by @juliusmarminge in pingdotgg/t3code#33501 * fix(mobile): a full swipe on a thread row finishes even if the pan is cancelled by @juliusmarminge in pingdotgg/t3code#33492 * fix(client): finishing a long background thread no longer freezes the app by @juliusmarminge in pingdotgg/t3code#33503 * feat(models): the model picker checks for new models when it opens by @t3dotgg in pingdotgg/t3code#33511 * fix(desktop): close focused DevTools with Cmd+W by @Yash-Singh1 in pingdotgg/t3code#33518 * chore(mobile): update react-native-pdf-jsi to 6.1.0 and link it on Android only by @juliusmarminge in pingdotgg/t3code#33504 * fix(mobile): the unfolded Duo sidebar no longer pops back in while resizing Files by @juliusmarminge in pingdotgg/t3code#33510 * fix(models): new models also surface the CLI update that supports them by @t3dotgg in pingdotgg/t3code#33515 * fix(web): clicked workspace areas no longer show the focus ring after a stray key by @t3dotgg in pingdotgg/t3code#33525 * chore(server): update Claude Agent SDK to 0.3.321 by @t3dotgg in pingdotgg/t3code#33530 **Full Changelog**: pingdotgg/t3code@v0.1.8-nightly.20261109.4429...v0.1.8-nightly.20261109.4433 </details> Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.8-nightly.20261109.4433
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cmd+W did not close Developer Tools when they had focus. The shortcut should close DevTools while retaining its existing renderer behavior for closing tabs and terminals.
Change
Add a hidden native menu item that closes the focused DevTools instance. Let Cmd+W reach the renderer in the app window, and keep repeated presses from closing multiple tabs or terminals.
Scope and approval
This is a focused fix for an obvious desktop shortcut bug. It changes only desktop menu and window shortcut handling.
Verification
All 31 focused tests and
vp run check:changedpassed. Electron runtime checks confirmed that the menu handler closes focused DevTools while leaving the app window open. Automated native keypress verification remains unconfirmed.