Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This aligns compact Android header titles and subtitles on a shared baseline while retaining single-line truncation. The change is presentation-only, with reported before/after device verification and no changes to navigation or data handling. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The compact header centred a smaller subtitle against the title, so its baseline sat above the title's. Render both as spans of one Text so they share a baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3f98409 to
7c1c2d4
Compare
|
Note Written by Verified on Android emulator (API 35) against a real dev serververified head in landscape split view at 216 dpi, focusing the composer opens the keyboard and switches the header to one line. the subtitle shares the title baseline on this head. for the before capture, i temporarily loaded the unchanged parent commit's header component into the same running app with the same thread, then restored the exact PR component. the parent's subtitle sits above the title baseline. this is a component comparison against the parent, not a full dismissing the keyboard restores the two-line header and thread sidebar; focusing again restores the aligned compact header. the files button also opens the real project tree and closes it again. no code changes or pushes were needed. existing head CI checks pass; no new automated checks were run for this verification-only pass. Not verifiedios cannot run on this linux VM. long-title truncation, a title containing the star character, dark theme, larger font sizes, and other device sizes were not exercised. a full |



On Android split view, while the composer has the keyboard, the thread header drops to one line, and the muted subtitle (
T3 Code · corex) sat about 2dp above the title's baseline. TheRowcentred the smaller subtitle against the larger title rather than aligning their text.Expo UI 58's
Rowonly aligns top, center or bottom, with no baseline option. So the compact title is now oneTextwith the subtitle as a smaller, muted span. Spans in one paragraph share a baseline. A long title still truncates the subtitle first, as before. The 8dp gap is now two spaces at the subtitle's size.The sidebar icon and the ✦ in the reported title were already aligned. The icon's centre is within 1px of the title's, both in the report and on the device. The ✦ is a character of the title text itself, so it already shares the title's line. Neither changed.
Scope and approval
A focused fix for an obvious visual bug, reported by a maintainer, under the focused bug-fix exception. It changes one file and only the compact header's text layout; no new behavior or settings.
Verified on a POCO M3 Pro (Android 13) with Smallest width set to 800dp and dev client 2.2.0 (fingerprint
fe047aa3). Before is main atdff0b1159b, after is3f9840959d. Same steps both times: open a thread, focus the composer, capture the header. On the device, the subtitle's text bottom moved from y=141 to y=144, the title's baseline.Before (top) and after (bottom), 2× crop, red line is the title baseline:
Zoomed: the subtitle sits above the baseline before and on it after:
After, with a long title: the subtitle is cut off first and stays on the same baseline:
vp run check:changedpasses.Not shown: a title containing ✦ on a device (the test data had none), larger tablets, and non-default font sizes.
Implemented by Claude Opus 5.5 in T3 Code (Claude Code harness).
🤖 Generated with Claude Code