Repository navigation
fix(web): stacked composer banners no longer show dark seam bands - #32683
Pulsar-Programmer wants to merge 2 commits into
Conversation
Only the banner touching the composer keeps the dark-mode seam shade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Removes dark seam bands between stacked composer banners while retaining the shade next to the composer. The change is confined to visual styling, with no effect on data or application behavior. You can add or adjust custom eligibility rules. Learn more. |
|
Quick check on intent: I read the shade between stacked banners as accidental. The |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Note Written by Takeover updatemerged
Verified in a real dev environmentverified unchanged head
before, main, nord dark: after, pr, matching composer data and crop: recorded interactions, dismissing the upper notice, restoring the branch, then arming a single fresh-session notice: real codex replies and the re-created notice stack: Not verifiednative electron, ios, and android clients; macos/windows rendering; remote relay/tunnel connections; other providers and browsers. this pass exercised the linux web client with real codex turns. no performance claim is made. |




Problem
When two or more notices stack above the composer in dark mode, every card gets the 10px dark "seam" shade that is only meant for where the bottom card meets the composer. The upper cards end up with dark bands between them. On the default theme it is faint, but on lighter dark themes (for example Nord from the community theme search) it is clearly visible.
To reproduce: in dark mode, open a thread with messages on a local checkout, switch the checkout to a different branch than the thread's, start typing (the "Branch changed" banner appears), then send
/clear(the "fresh session" banner appears above it).Change
The seam colour in
--background-image-composer-seam-abovenow reads--chat-composer-attached-seam, falling back to the currentrgb(0 0 0 / 18%).ComposerBanner.Attachmentsets that variable totransparentwhen another attachment follows it, so only the card touching the composer keeps the shade. Single banners and the banner-to-composer seam look the same as before.Scope and approval
Small, focused fix for a visual bug: 3 changed lines in
ComposerBanner.tsxandindex.css, with no behaviour change. It is the same seam effect, applied only where it was meant to be.Verification
Captured in a dev build (
vp run dev, Replay provider) with two real stacked banners (fresh session plus branch changed), before and after the fix, in dark mode.Nord theme (a community theme installed through Settings → Appearance → Add theme). Before: a dark band under the fresh-session banner. After: the cards join flat.
Default dark theme. The same band exists but is only about 2/255 darker, so it is barely visible:
A pixel diff of the composer area confirms the only changed pixels are the 10 rows above the seam between the two banners (up to 11/255 on Nord, 2/255 on default). The bottom banner's seam into the composer is unchanged.
vp run check:changedpasses.Made with Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code