Repository navigation
fix(mobile): an answered question no longer shows its raw item JSON - #31330
Jacksondr5 wants to merge 1 commit into
Conversation
Expanding an answered question drew the raw item JSON under the question and answer. Web already leaves it out for these rows (`TimelineWorkEntryRow` skips the inspector when `workEntry.questionAnswer` is set); mobile had no such check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Expanded answered questions on mobile retain their question-and-answer history without displaying redundant raw item JSON, matching web behavior. The change is presentation-only and leaves other work-row details unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Problem
On mobile, expanding an answered question draws the question and answer, then the raw item JSON under them. Web shows only the question and answer:
TimelineWorkEntryRowskips the inspector whenworkEntry.questionAnsweris set. Mobile'sthread-work-log.tsxhas no such check, sofullDetailis built and drawn for these rows.Change
fullDetailnow also requires!row.workEntry.questionAnswer, matching web. Other work rows keep their detail.Scope and approval
This is a very small, focused fix for an obvious bug: one condition in one file, no contract or shared code, and it makes mobile match what web already does. It doesn't touch the folded row's label, which #18544 is working on.
Verification
vp run typecheckinapps/mobileandvp linton the changed file pass. This row has no existing rendering test, so I checked it on a device.mainat20e92ffe02and on this branch.Answered question, expanded, before: the question and answer, then the raw item JSON.
Answered question, expanded, after: only the question and answer.
Ordinary work row, expanded, after: a
pwdcommand row still shows its command and output.Not verified: iOS, other providers' question items, and multi-question answers. Other tool row types beyond the
pwdcommand weren't expanded.Claude Opus 5.5 in Claude Code built this; GPT-6.1-Sol in Codex ran the device checks. Claude Opus 5.5, an AI agent, on Jackson's behalf.
🤖 Generated with Claude Code