Skip to content

fix(mobile): an answered question no longer shows its raw item JSON - #31330

Open
Jacksondr5 wants to merge 1 commit into
pingdotgg:mainfrom
Jacksondr5:fix/mobile-answered-question-no-raw-json
Open

Jacksondr5 wants to merge 1 commit into
pingdotgg:mainfrom
Jacksondr5:fix/mobile-answered-question-no-raw-json

Conversation

@Jacksondr5

Copy link
Copy Markdown
Contributor

Problem

On mobile, expanding an answered question draws the question and answer, then the raw item JSON under them. Web shows only the question and answer: TimelineWorkEntryRow skips the inspector when workEntry.questionAnswer is set. Mobile's thread-work-log.tsx has no such check, so fullDetail is built and drawn for these rows.

Change

fullDetail now also requires !row.workEntry.questionAnswer, matching web. Other work rows keep their detail.

Scope and approval

This is a very small, focused fix for an obvious bug: one condition in one file, no contract or shared code, and it makes mobile match what web already does. It doesn't touch the folded row's label, which #18544 is working on.

Verification

  • vp run typecheck in apps/mobile and vp lint on the changed file pass. This row has no existing rendering test, so I checked it on a device.
  • Android emulator (Pixel 8 AVD, Android 16, 1080x2400, light theme) with the dev client, against an isolated dev server. A Claude Haiku 5.5 thread asked one question with its question tool, and it was answered "Red". The same saved conversation was opened on main at 20e92ffe02 and on this branch.

Answered question, expanded, before: the question and answer, then the raw item JSON.

Answered question expanded on main, before: raw item JSON under the question and answer

Answered question, expanded, after: only the question and answer.

Answered question expanded on this branch, after: only the question and answer

Ordinary work row, expanded, after: a pwd command row still shows its command and output.

Ordinary pwd work row expanded on this branch, after: command and output still shown

Not verified: iOS, other providers' question items, and multi-question answers. Other tool row types beyond the pwd command weren't expanded.

Claude Opus 5.5 in Claude Code built this; GPT-6.1-Sol in Codex ran the device checks. Claude Opus 5.5, an AI agent, on Jackson's behalf.

🤖 Generated with Claude Code

Expanding an answered question drew the raw item JSON under the question and
answer. Web already leaves it out for these rows (`TimelineWorkEntryRow` skips
the inspector when `workEntry.questionAnswer` is set); mobile had no such check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 5, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 333af6d

Macroscope's review found this PR approvable — Expanded answered questions on mobile retain their question-and-answer history without displaying redundant raw item JSON, matching web behavior. The change is presentation-only and leaves other work-row details unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Expanded thread work-log rows no longer calculate or render fullDetail for question-and-answer entries. Other rows retain the existing full-detail behavior.

Changes: Thread work-log rows

Layer / File(s) Summary
Full-detail eligibility
apps/mobile/src/features/threads/thread-work-log.tsx
The fullDetail condition excludes question-and-answer entries. Other expanded rows retain the existing eligibility checks.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 333af

The intended answered-question display remains available, while raw item JSON is omitted.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly and concisely describes the main mobile fix: answered questions no longer display raw item JSON. It uses an appropriate conventional commit format.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the cause and fix, justifies the focused scope, reports targeted checks and device ver…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the cause and fix, justifies the focused scope, reports targeted checks and device verification, includes before-and-after UI evidence, and identifies unverified cases.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 67eebac and 333af6d.

Files selected for processing: 1

  • apps/mobile/src/features/threads/thread-work-log.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant