Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { createRef } from "react";
import { expect, it, vi } from "vite-plus/test";
import { page, userEvent } from "vite-plus/test/browser";

import { act, render } from "../../../test/render";
import { PreviewChromeRow } from "./PreviewChromeRow";

it("ignores composing keys in the address bar", async () => {
const onSubmit = vi.fn();
await using _screen = await render(
<PreviewChromeRow
url="https://example.com/"
loading={false}
canGoBack={false}
canGoForward={false}
refreshDisabled={false}
urlInputRef={createRef()}
onBack={() => {}}
onForward={() => {}}
onRefresh={() => {}}
onSubmit={onSubmit}
/>,
);
const input = page.getByRole("textbox", { name: "Search or enter URL" });
await input.fill("東京");

for (const composition of [
{ key: "Enter", isComposing: true, keyCode: 13 },
{ key: "Enter", isComposing: false, keyCode: 229 },
{ key: "Escape", isComposing: true, keyCode: 27 },
{ key: "Escape", isComposing: false, keyCode: 229 },
]) {
const event = new KeyboardEvent("keydown", { ...composition, bubbles: true, cancelable: true });
await act(() => input.element().dispatchEvent(event));
if (composition.key === "Enter") expect(event.defaultPrevented).toBe(true);
await expect.element(input).toHaveValue("東京");
await expect.element(input).toHaveFocus();
}
expect(onSubmit).not.toHaveBeenCalled();

await userEvent.keyboard("{Enter}");
expect(onSubmit).toHaveBeenCalledExactlyOnceWith("東京");
});
4 changes: 4 additions & 0 deletions apps/web/src/components/preview/PreviewChromeRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,10 @@ export function PreviewChromeRow({
setInputFocused(false);
}}
onKeyDown={(event) => {
if (event.nativeEvent.isComposing || event.keyCode === 229) {
if (event.key === "Enter") event.preventDefault();
return;
}
if (event.key === "Enter") submit(event);
if (event.key === "Escape") {
event.preventDefault();
Expand Down
Loading