[luminousify]

Summary

omp (oh-my-pi) askDialog elicits a JSON-schema form the generic ACP fallback cannot read, so its ask tool breaks in three visible ways (#23505). This adds an OMP form handler at the existing provider flavor boundary, mirroring droidAcp.ts.

 generic handleElicitation fallback
- options = enum values only
- every property -> its own question (q0__other becomes step 2/2)
- header = title, question = description   (omp sends them reversed)
+ ompAcp.ts extractOmpElicitationForm
+ options = oneOf consts (labels with descriptions)
+ q{N}__other folded into the question's native custom answer
+ header = description (fallback "Question N"), question = title
+ respond: selected label -> q{N}; custom text -> q{N}__other

Selected when the registry agent is omp or the local command basename is omp / omp.exe / omp.cmd. Unrecognized forms keep the generic fallback; other providers are untouched.

Why the answer routing matters: omp reads q{N} as one of the option labels and q{N}__other as the custom text, and drops a q{N} value that is not a label - so on current main a typed custom answer is silently discarded, not just mis-rendered.

Evidence

• Before (flavor wiring disabled, tests added first):
  Tests 3 failed | 1 passed - option-label, custom-answer, and cancellation scenarios fail; only the unrelated-form fallback passes.
  After (wiring restored): Tests 4 passed - OMP elicitation $scenario replay cases.

• Full AcpAdapterV2.test.ts: 91 passed | 1 failed; the one failure (native session forks) reproduces on clean main in this environment and is unrelated.

• vp lint clean on the three files; tsc --noEmit clean for provider-acp-registry and apps/server; commit hooks (fmt, lint, knip) passed.

• Wire shape verified against omp 18.16.0 packages/coding-agent/src/modes/acp/acp-agent.ts (askDialog -> unstable_createElicitation), live-reproduced beforehand: card showed 2/2, no options, header/question swapped, custom answer dropped.

Scope limits: multi-select forms (items.anyOf) are not recognized - the generated ACP decoder rejects that schema upstream of the flavor hook, so they never reach extractElicitationForm. An attachment-appended option selection degrades to a custom answer; omp resolves attachment references in custom input.

Fixes #23505 (single-choice case). Independently implemented from the omp wire contract; happy to defer to #24012 if maintainers prefer that branch - the tests here cover selected labels, custom-answer routing, cancellation, and generic fallback either way.

Merge Danger

Door: two-way - one new file, a six-line wiring change, additive tests; deleting the wiring reverts behavior for everyone except local omp installs.

Blast Radius: narrow - only OMP-detected instances change; the generic fallback and every other provider keep their exact current path.

[macroscopeapp]

Approvability

Verdict: Approved at c92fdfa

Macroscope's review found this PR approvable — OMP ask forms now display choices as single questions and translate custom answers into OMP’s expected response fields. The change is provider-scoped, preserves fallback handling, and retains explicit user input before sending responses.

^{You can add or adjust custom eligibility rules. Learn more.}