[only21mil]

Problem

Release Smoke checks lockfile resolution by copying the repo's manifests into a temp folder, deleting the lockfile and running vp install --lockfile-only. It copied a hand-kept list of manifests, and that list has drifted. evals and infra/task-cache are workspace packages with importers in pnpm-lock.yaml, but the smoke never copied them, so it never resolved them, and it still passed. Every new package also needs a second edit to that list, which is why #14693, #18694 and #24180 each add a line to it.

Change

The smoke now builds its fixture the way check:changed already does for its unused-patch check. Workspace manifests come from readWorkspace(), and mobile's file: module manifests come from apps/mobile/modules. The root manifest, workspace config, lockfile, apps/mobile/deps and patches are copied as before.

The smoke also compares the regenerated lockfile with the committed one and fails if any committed importer is missing. That uses pnpm's own output as the reference, so it also catches a workspace pattern readWorkspace() can't read, such as **.

Release behavior doesn't change. Only server, desktop, web and contracts get version bumps, and the updater manifest steps are untouched.

Scope and approval

This is a small, focused fix to a CI script, so it qualifies without a prior issue. #23988 lists it as an out-of-scope follow-up: "release-smoke's hard-coded workspace file list can drift from readWorkspace()."

#14693 and #33093 landed with a line each in the list. The merges with main dropped those lines, because discovery already includes both packages. #18694 and #24180 would drop their line after this lands. #23700 edits a different part of the same file.

Verification

Before, on main 0a9abddaee: the smoke passes but resolves only 40 of the lockfile's 42 importers. evals and infra/task-cache are missing.

After, on this branch merged with the same main: all 42 resolve.

All runs used Node 26.12.1 and pnpm 12.14.0, the versions package.json pins, on Linux.

• Base plus only the new importer check, node scripts/release-smoke.ts: fails with Release smoke did not resolve workspace packages: evals, infra/task-cache.
• This branch: Release smoke checks passed. All 42 committed importers resolve on main 0a9abddaee, and the four release version targets are still bumped to 9.9.9-smoke.0.
• New package: a temporary packages/release-smoke-probe with its lockfile importer, then removed. This branch passes and resolves it with no list edit. Base plus the check fails, naming evals, infra/task-cache, packages/release-smoke-probe.
• vp run check:changed 82b10d546c1041d8eff40425f076d61f608d518f: format, lint, knip and typecheck pass.

Not checked:

• The CI runner. Locally, pnpm resolved from cached registry metadata.
• .pnpmfile.cjs. The smoke didn't copy it before and still doesn't; check:changed does. I left it out to keep this to one problem.
• Native Windows or macOS. The smoke's updater-manifest steps only use YAML fixtures, and this change doesn't touch them.
• UI. This is a CI script with no screen.

Prior PRs

• ci: unused dependency patches fail in check:changed, not after push #23988 by t3dotgg named this follow-up.
• feat(scripts): one command checks what the branch changed #22767 by t3dotgg exported readWorkspace(), which this reuses.
• Fix release finalize lockfile refresh #608 by t3dotgg started the release smoke's lockfile check.
• feat(provider-kiro): add Kiro as an ACP provider #14693 by juliusmarminge, feat(source-control): add Tangled support #18694 by nozamdavid and feat(source-control): add Entire as a source control host #24180 by peyton-alt each add a workspace manifest to the old list.

Generated with Claude Opus 5.5 and GPT-6.1 Terra and GPT-6.1 Sol in T3 Code Nightly

[macroscopeapp]

Approvability

Verdict: Approved at 39f99d5

Macroscope's review found this PR approvable — The release smoke now discovers workspace manifests automatically and checks that no committed lockfile importer is omitted. Changes are confined to temporary test fixtures and validation, without altering product defaults or release publishing.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Walkthrough

The release smoke script now discovers workspace manifests dynamically. After it regenerates a temporary lockfile, it checks that the lockfile contains every importer from the repository lockfile.

Changes: Release smoke checks

Layer / File(s)	Summary
Discover workspace manifests scripts/release-smoke.ts	The fixture manifest list now comes from workspace package directories and existing mobile module manifests instead of a fixed list.
Check regenerated lockfile importers scripts/release-smoke.ts	A helper reads importer names from the lockfile’s top-level importers section. The smoke test reports repository importers missing from the regenerated lockfile.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to f0126

The mobile modules directory is required by the release-smoke fixture. No actionable merge-blocking risk is established; normal checks remain appropriate.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the CI fix: the release smoke check now resolves every workspace package.
Description check		The description includes all required sections. It explains the problem and change, justifies the scope, and provides focused verification results and limitations.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 1
• Charged: $0.25
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Merged current main (71646e031a) into the existing contributor branch without rebasing. Resolved the release-smoke manifest-list conflict by keeping automatic workspace discovery, which includes the packages added on main. The diff remains one file, with 33 additions and 49 deletions.

Verified merged head 536df8eb222b46c6f7c3c4f4c929ce02833f06ee through blacksmith-check: vp run check:changed github/main passed format, lint, both knip checks, and the affected scripts typecheck. vp run release:smoke passed, including all six relay-state tests and lockfile importer coverage. Two independent read-only reviews approved this exact head with no actionable findings.

GitHub reports no conflicts. Fresh CI is running. This is a CI-script-only change; native updater execution and release publication remain unverified.

[only21mil]

Note

🤖 Opus 5.5 replying on behalf of Victor.

Merged main to clear the conflict in f012686e2b. Main #33093 added packages/source-control-cursor-origin/package.json to the hand-kept list this PR replaces. The merge drops that line, and readWorkspace() already includes the package through packages/*. Nothing else changed: the diff against main is still scripts/release-smoke.ts only.

On the merged head, vp run release:smoke passes and resolves all 42 committed importers. vp run check:changed passes. The description now has before and after captures of the smoke output. With main's list and only the importer check, the smoke still fails on evals, infra/task-cache. No UI: this is a CI script.

[coderabbitai]

Additional comments: 1

scripts/release-smoke.ts: 1

16-18: Trivial · Maintainability & Code Quality · Low value

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Guard the mobile modules directory read.

NodeFS.readdirSync throws ENOENT if apps/mobile/modules does not exist. This includes a sparse checkout or a future rename. The fixture setup then fails with an unrelated error. The other optional paths in this function use existsSync guards, for example apps/mobile/deps and patches. Use the same guard here.

Review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 0a9abdd
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 88f2b102-58f7-4722-b550-90841042b0d2

Commits

Reviewing files that changed from the base of the PR and between 536df8e and f012686.

Files selected for processing: 1

• scripts/release-smoke.ts

Limit details: You’ve used all 10 included reviews currently available.