Repository navigation
fix(mobile): Android menus use the theme's card color and rounded corners - #28034
Umais-Adeed wants to merge 2 commits into
Conversation
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Android menus switch to the theme’s grouped-card color and scaled 16dp rounded corners. This is a low-risk visual change, but a human must confirm the new default appearance. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Note Written by Takeover updateMerged current Verified on Android emulator (API 35) against a real dev serverVerified head Reproduced the gray surface and small corners on Also exercised the inline menu with Gboard visible: both rows and the Project submenu render, selection works on the first tap, and the keyboard stays open. One initial opening showed only the first row; after reopening the app and waiting for the keyboard to settle, both rows rendered. I could not establish that transient result as a PR regression. No source changes were needed. Existing CI reports 29 successful checks; no new checks were run for this verification-only pass. Before, root menu on main: After, root menu on the PR: Before, Project submenu on main: After, Project submenu on the PR: Before, keyboard-visible menu on main: After, keyboard-visible menu on the PR: Interaction recording, inspected and playback/seek checked after upload: Not verified
|
…ners Android dropdown menus drew on the theme's raised surface with Material's 4dp corners. Several themes keep that surface nearly neutral (Grove dark renders gray over a green screen), so menus looked detached from the app. Menus now use the grouped-card color shared by settings rows, and the same 16dp radius as the composer's floating command popover, scaled with text size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2c0e73b to
549f8a9
Compare






Problem
Android dropdown menus (the thread filter and other anchored menus) draw on the theme's raised surface with Material's default 4dp corners. Several themes keep that surface nearly neutral, so in Grove dark the menu renders gray over a green screen. Its square corners also don't match the rounded cards and popovers used everywhere else in the app.
Change
--color-grouped-card, the theme-tinted card color already used by settings rows, so they follow the active theme. Material You still maps it to its own surface container.androidControlSizingand applied to both the ComposeDropdownMenu(cornerRadius) and the inline keyboard-visible variant.3 files, +11/−4. Android only. iOS uses the native menu and is unchanged.
Scope and approval
This is a small visual consistency fix: menus should use the app's theme colors and corner radius instead of Material defaults. It doesn't change any behavior, entries or workflow. It's also proposed in Ideas discussion #27985, together with a separate project-logo change that I'm holding until it's approved. Related: #14219 (Android looking inconsistent with the rest of the app).
Verification
Tested on an Android emulator (API 35) with a dev client and the showcase demo environments, comparing upstream
80a2351to this branch:Not checked: light themes, Material You dynamic color on a physical device, and the inline keyboard-visible variant (same token and radius, so the change is identical by code).
Done with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code