Repository navigation
IDEA: separate the composer pickers and preserve draft input - #27929
Draft
bmdavis419 wants to merge 5 commits into
Draft
bmdavis419 wants to merge 5 commits into
bmdavis419 wants to merge 5 commits into
Conversation
Keep paths and code literal through paste and display, and splice multiline text at the caret. The path and inline-code paste handling builds on Julius Marminge’s work in #25264. Preserve newer drafts and queued-edit context during asynchronous sends. Share primary actions across phone layouts, leave Space activation to sidebar rows, and skip mobile-only text measurements on desktop.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDEA for discussion: keep the composer quiet at rest, make its two pickers discoverable, and preserve what the user meant to send.
Proposed picker treatment
Before / after
Important files
apps/web/src/components/chat/ComposerControlsBar.tsx— model/effort divider and adjoining hit targets.apps/web/src/components/ComposerPromptEditorTiptap.tsx— paste and caret behavior.apps/web/src/composerDraftStore.ts— stale-send guard and queued-edit recovery.apps/web/src/components/chat/ChatComposer.tsx— shared primary actions and mobile-only wrap measurement.Validation:
vp run check:changedpassed (377 affected tests, plus compiler checks). Exercised independent picker menus, exact pasted text through a Replay turn, and Stop at a 390px browser width. Measured 0px between the hovered model button and the divider.Built with Codex in T3 Code · gpt-6.1 sol on medium reasoning.