Skip to content

fix(marketing): show other download platforms for the detected OS - #26703

Closed
BenyominMandel wants to merge 1 commit into
pingdotgg:mainfrom
BenyominMandel:fix/marketing-other-platforms
Closed

BenyominMandel wants to merge 1 commit into
pingdotgg:mainfrom
BenyominMandel:fix/marketing-other-platforms

Conversation

@BenyominMandel

Copy link
Copy Markdown

Problem

On Windows and Linux, the secondary download button always says “Windows · Linux · other”, even though the main button already adapts to the visitor's OS. This repeats the current platform and omits macOS.

To reproduce, open the homepage on Windows or Linux and scroll to the final download section.

Change

Use the existing OS detection to update the secondary button alongside the main download label:

  • Windows: macOS · Linux · other
  • macOS: Windows · Linux · other
  • Linux: macOS · Windows · other

Scope and approval

This is a small, focused fix for an obvious mismatch between the existing OS-aware main button and its secondary platform list. It uses the small-bug exception in CONTRIBUTING.md. The change is confined to the marketing homepage.

Verification

  • Ran the repository's check:changed script directly with node and the local Vite+ binary on PATH. Its format step passed; Astro checked all 22 marketing files with 0 errors, 0 warnings, and 0 hints. The wrapper was bypassed because it added unrelated package-manager lockfile metadata; that metadata is excluded from this commit.
  • Used Chromium with simulated Windows, macOS, and Linux user agents. Confirmed the primary and secondary labels match each platform and the secondary link still points to /download.
  • Captured matching Windows before/after screenshots.
before-windows after-windows
  • OS detection was checked through simulated browser user agents, not three native operating systems. Full CI has not run yet.

Written with GPT-6.1 sol in the Codex desktop app.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T22:31:03.978712Z 219853f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 219853f

Macroscope's review found this PR approvable — The secondary download link now lists alternative platforms based on the visitor’s detected OS. Only its display text changes; download destinations and selection behavior remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9826dbb and 219853f.

Files selected for processing: 1
  • apps/marketing/src/pages/index.astro

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The marketing homepage now updates the alternate-platform CTA label for detected macOS, Windows, or Linux platforms. For unrecognized platforms, the existing label remains unchanged.

Changes: Homepage CTA

Layer / File(s) Summary
Update alternate-platform CTA label
apps/marketing/src/pages/index.astro
The CTA link gains the cta-other-platforms ID. The script lists the two other platforms for detected macOS, Windows, or Linux systems. The label remains unchanged when no platform is detected.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to 21985

The platform-aware download CTA is ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: updating the marketing download link to show platforms other than the detected operating system.
Description check Passed The description includes the problem, implementation, scope justification, verification steps, observed results, screenshot evidence, testing limits, and agent disclosure. It satisfies the required te…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the problem, implementation, scope justification, verification steps, observed results, screenshot evidence, testing limits, and agent disclosure. It satisfies the required template.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@BenyominMandel

Copy link
Copy Markdown
Author

Closing because the latest homepage update changes this button to “Other platforms,” which resolves the original misleading platform list. This PR is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant