Skip to content

fix(mobile): overlay sidebar header blurs content scrolling under it - #26580

Merged
juliusmarminge merged 1 commit into
mainfrom
t3/fix-sidebar-header-and-insets
Oct 28, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3/fix-sidebar-header-and-insets

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

On the iPhone Duo unfolded in portrait, and in the iPad Split View sidebar, the sidebar header was solid. Content stopped at a hard edge below it instead of scrolling under a blurred header.

In picker mode, WorkspaceRootScreen padded the column by the top safe-area inset and passed top: 0 to its children. The lists use UIKit-managed insets (contentInsetAdjustmentBehavior="automatic") and a scroll-view marker to get the header's scroll-edge blur. The padding kept content out from under the header, so there was nothing to blur, and the zeroed inset threw off the tabs' offset math. This change drops the padding and the override, so picker mode gets the same insets as every other layout.

The file is iOS-only; Android uses WorkspaceRootScreen.android.tsx.

Evidence

Each pair is before (left) and after (right), scrolled to the same position.

iPhone Duo, portrait unfolded, Threads
Duo portrait Threads before/after

iPhone Duo, portrait unfolded, Pull Requests
Duo portrait PRs before/after

iPad, portrait Split View sidebar
iPad portrait sidebar before/after

Other Duo poses after the fix, from left: landscape Threads, landscape PRs, half-open Settings, folded cover. They all keep the blur and correct insets.
Other Duo poses after

Verification

  • Simulators: iPhone Duo on iOS 27.1 and iPad on iOS 26.5.
  • Tabs: Threads, PRs, and Settings, both at rest and scrolled. At rest, the portrait layout matches landscape.
  • vp run check:changed passes.

🤖 Generated with Claude Code (Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 30d71fc

Macroscope's review found this PR approvable — Adjusts mobile sidebar safe-area handling so content can scroll beneath the transparent header. The change is confined to presentation, with no persistent-data or product-default changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 30eb7e7 into main Oct 28, 2026
28 of 29 checks passed
@juliusmarminge
juliusmarminge deleted the t3/fix-sidebar-header-and-insets branch October 28, 2026 17:53
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 28, 2026
## What's Changed
* ci(release): desktop builds stop hitting the npm registry for staged installs by @t3dotgg in pingdotgg/t3code#26458
* feat(web): boring sidebar can show folder threads on two lines by @t3dotgg in pingdotgg/t3code#26463
* fix(server): release completed pull request sweep data by @juliusmarminge in pingdotgg/t3code#25177
* test(evals): device manager cases for mcp-tool-use by @gabrielelpidio in pingdotgg/t3code#25850
* fix(server): agents drive simulators through the device tools instead of ssh by @gabrielelpidio in pingdotgg/t3code#25661
* fix(mobile): overlay sidebar header blurs content scrolling under it by @juliusmarminge in pingdotgg/t3code#26580
* fix(web): numbered composer lists nest and lift correctly by @michal-billtech in pingdotgg/t3code#17138
* feat(mobile): add dynamic workflows to the Agents sheet by @Bil0000 in pingdotgg/t3code#18642
* fix(ci): Android merges stop cutting a new Play Store build every time by @juliusmarminge in pingdotgg/t3code#26596

## New Contributors
* @michal-billtech made their first contribution in pingdotgg/t3code#17138

**Full Changelog**: pingdotgg/t3code@v0.1.4-nightly.20261028.3824...v0.1.4-nightly.20261028.3838

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.4-nightly.20261028.3838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant