Repository navigation
fix(build): keep effect out of the public-config bootstrap - #26371
Conversation
#26350 imported effect/Function into scripts/lib/public-config.ts, which mobile app.config.ts and the server vite config load in deploy jobs whose installs do not resolve effect from the repo root. That broke every EAS production job (expo config exits 1 in eas env:pull) and the production relay deploy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Removes the Effect dependency from public-config bootstrapping while preserving repository-root resolution and environment loading. The change does not alter product defaults or broaden diagnostic suppressions. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Repository root resolution scripts/lib/public-config.ts |
The module removes the pipe import and resolves REPO_ROOT with NodePath.resolve and "../../..". |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: t3dotgg
Merge Risk: 
Minimal · up to bc51f
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
3 · 
1
-
Failed checks: 1 warning Passed checks: 3 passedFull details: Description check
-
Resolution
Add the required Scope and approval section. Link the relevant issue or approval discussion, or explain why this focused bug fix qualifies without one. Add a Verification section with the commands or manual checks performed, their observed results, and any checks that could not be run. State the agent model and harness at the end if applicable, using the required template structure and headings.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Main has been red since https://git.cafe/pingdotgg/t3code/pulls/26350: it imported
effect/Functionintoscripts/lib/public-config.ts. Mobileapp.config.tsandapps/server/vite.config.tsload that file in the EAS production and production relay deploy jobs, whose installs do not resolveeffectfrom the repo root.expo config --jsonexits 1 insideeas env:pull, so every EAS production job fails, and the relay deploy fails to load the server vite config.Restores a dependency-free
REPO_ROOT(NodePath.resolve(file, "../../.."), equivalent to threedirnamecalls). The file's header already says it runs before any Effect runtime exists.Done with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code