Repository navigation
fix(web): prevent image thumbnails from warping during repaints - #26308
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This change isolates image-thumbnail rendering to prevent Chromium repaint warping in guest messages and the user timeline. It preserves existing sizing, image loading, and preview interactions, with risk confined to presentation. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add GPU transforms to thumbnails apps/web/src/components/chat/GuestMessageAttachments.tsx, apps/web/src/components/chat/TimelineUserMessageRow.tsx |
Both thumbnail class lists now include transform-gpu. The guest attachment comment describes raster isolation in Chromium. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested labels: bugfix, size:S
Suggested reviewers: t3dotgg, juliusmarminge
Merge Risk: 
Minimal · up to 834e3
-
No actionable merge-blocking risk is established for these thumbnail styling changes.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description includes all required sections, explains the visual bug and fix, identifies the focused scope, and reports specific capture-based verification results and limitations. It is mostly complete, although it does not include the template-requested before/after screenshots for this UI change.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
…dotgg#26308) (cherry picked from commit afc2334)
Problem
Image thumbnails in user messages could appear to shift or warp during nearby repaints while a thread was active.
Change
Apply GPU transforms to thumbnails in both guest and timeline user messages. This isolates their raster from nearby repaint activity in Chromium.
Scope and approval
This is a focused fix for a visual bug in the two user-message attachment paths.
Verification
A lossless capture comparison showed identical thumbnail pixels across 19 frames with the change; with it disabled, 1,957 pixels changed. The video’s keyframe timing near the observed shift did not establish its cause. The provided thread does not record focused tests or manual checks beyond these captures.