Skip to content

fix(web): prevent image thumbnails from warping during repaints - #26308

Merged
Yash-Singh1 merged 1 commit into
mainfrom
t3/fix-image-preview-warp
Oct 28, 2026
Merged

Yash-Singh1 merged 1 commit into
mainfrom
t3/fix-image-preview-warp

Conversation

@Yash-Singh1

Copy link
Copy Markdown
Collaborator

Problem

Image thumbnails in user messages could appear to shift or warp during nearby repaints while a thread was active.

Change

Apply GPU transforms to thumbnails in both guest and timeline user messages. This isolates their raster from nearby repaint activity in Chromium.

Scope and approval

This is a focused fix for a visual bug in the two user-message attachment paths.

Verification

A lossless capture comparison showed identical thumbnail pixels across 19 frames with the change; with it disabled, 1,957 pixels changed. The video’s keyframe timing near the observed shift did not establish its cause. The provided thread does not record focused tests or manual checks beyond these captures.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 834e38c

Macroscope's review found this PR approvable — This change isolates image-thumbnail rendering to prevent Chromium repaint warping in guest messages and the user timeline. It preserves existing sizing, image loading, and preview interactions, with risk confined to presentation.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9c6429d and 834e38c.

Files selected for processing: 2
  • apps/web/src/components/chat/GuestMessageAttachments.tsx
  • apps/web/src/components/chat/TimelineUserMessageRow.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

Walkthrough

The guest attachment and timeline user-message image thumbnails now include transform-gpu in their class lists. Existing image behavior and cover styling remain unchanged.

Changes: Chat thumbnail styling

Layer / File(s) Summary
Add GPU transforms to thumbnails
apps/web/src/components/chat/GuestMessageAttachments.tsx, apps/web/src/components/chat/TimelineUserMessageRow.tsx
Both thumbnail class lists now include transform-gpu. The guest attachment comment describes raster isolation in Chromium.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested labels: bugfix, size:S

Suggested reviewers: t3dotgg, juliusmarminge

Merge Risk: Minimal · up to 834e3

No actionable merge-blocking risk is established for these thumbnail styling changes.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: preventing web image thumbnails from warping during repaints.
Description check Passed The description includes all required sections, explains the visual bug and fix, identifies the focused scope, and reports specific capture-based verification results and limitations. It is mostly com…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes all required sections, explains the visual bug and fix, identifies the focused scope, and reports specific capture-based verification results and limitations. It is mostly complete, although it does not include the template-requested before/after screenshots for this UI change.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Yash-Singh1
Yash-Singh1 merged commit afc2334 into main Oct 28, 2026
30 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3/fix-image-preview-warp branch October 28, 2026 05:23
Pipyakas pushed a commit to Pipyakas/t3code that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant