Skip to content

fix(web): long "Next" titles in the PR guide no longer push the button off-screen - #26225

Open
faetalize wants to merge 5 commits into
pingdotgg:mainfrom
faetalize:fix/pr-guide-next-button-overflow
Open

faetalize wants to merge 5 commits into
pingdotgg:mainfrom
faetalize:fix/pr-guide-next-button-overflow

Conversation

@faetalize

Copy link
Copy Markdown

Problem

image

Well.. it's self explanatory. Long buttons get clipped in the PR Guide feature.

Change

Simple. Just added shrink as a layout class to GuideStop.tsx's button.

Scope and approval

This is a one line fix, no need for an issue imo. And it doesn't restyle.

Verification

Before:
image

After:
image

vp run check:changed passes

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at e82294e

Macroscope's review found this PR approvable — Allows the PR guide’s Next button to shrink so long titles truncate rather than push it off-screen. The change is local to presentation and leaves navigation behavior unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4cf9ac1 and c49188d.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0894156 and e82294e.

Files selected for processing: 1
  • apps/web/src/components/pullRequest/guide/GuideStop.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The GuideStop “Next” button adds the shrink class to its existing min-w-0 class.

Changes: Guide Stop button sizing

Layer / File(s) Summary
Next button sizing
apps/web/src/components/pullRequest/guide/GuideStop.tsx
The “Next” button adds shrink alongside min-w-0.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: akash3444

Merge Risk: Minimal · previous review e8229

No actionable merge-blocking risk was found in this focused layout change.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly describes the web fix for long PR Guide button titles and follows the repository’s conventional commit style.
Description check Passed The description includes Problem, Change, Scope and approval, and Verification sections. It explains the clipping issue, identifies the shrink class fix, provides before and after screenshots, and r…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes Problem, Change, Scope and approval, and Verification sections. It explains the clipping issue, identifies the shrink class fix, provides before and after screenshots, and reports the focused check result.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@faetalize

Copy link
Copy Markdown
Author

This is worth merging asap tbh.

@faetalize

Copy link
Copy Markdown
Author

rebased.

@faetalize

Copy link
Copy Markdown
Author

once again.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant