Add desktop update release notes tooltip - #2520
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size:L
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved This PR adds a UI enhancement - a richer tooltip for desktop updates showing version information and a release notes link. The changes are self-contained, include unit tests, and don't affect any sensitive code paths. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
- Add a shared tooltip popup for desktop update states - Link update status to the correct GitHub release notes - Cover latest version and release URL helpers with tests
2f2ee1e to
5f6f683
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Wrong nightly release tag URL
- Removed the nightly-specific
nightly-vprefix branch so both channels usev${latestVersion}, matching the actual tag format produced by the nightly release script.
- Removed the nightly-specific
Or push these changes by commenting:
@cursor push 07d5431b7d
Preview (07d5431b7d)
diff --git a/apps/web/src/components/desktopUpdate.logic.test.ts b/apps/web/src/components/desktopUpdate.logic.test.ts
--- a/apps/web/src/components/desktopUpdate.logic.test.ts
+++ b/apps/web/src/components/desktopUpdate.logic.test.ts
@@ -324,7 +324,7 @@
channel: "nightly",
availableVersion: "1.1.0-nightly.20260501.17",
}),
- ).toBe("https://github.com/pingdotgg/t3code/releases/tag/nightly-v1.1.0-nightly.20260501.17");
+ ).toBe("https://github.com/pingdotgg/t3code/releases/tag/v1.1.0-nightly.20260501.17");
});
it("falls back to the releases page when no latest version is known", () => {
diff --git a/apps/web/src/components/desktopUpdate.logic.ts b/apps/web/src/components/desktopUpdate.logic.ts
--- a/apps/web/src/components/desktopUpdate.logic.ts
+++ b/apps/web/src/components/desktopUpdate.logic.ts
@@ -88,7 +88,7 @@
return DESKTOP_UPDATE_RELEASES_URL;
}
- const tag = state.channel === "nightly" ? `nightly-v${latestVersion}` : `v${latestVersion}`;
+ const tag = `v${latestVersion}`;
return `${DESKTOP_UPDATE_RELEASES_URL}/tag/${encodeURIComponent(tag)}`;
}You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 5f6f683. Configure here.
| } | ||
|
|
||
| const tag = state.channel === "nightly" ? `nightly-v${latestVersion}` : `v${latestVersion}`; | ||
| return `${DESKTOP_UPDATE_RELEASES_URL}/tag/${encodeURIComponent(tag)}`; |
There was a problem hiding this comment.
Wrong nightly release tag URL
High Severity
For the nightly update channel, getDesktopUpdateReleaseNotesUrl builds GitHub release tags with a nightly-v prefix, but nightly releases are published as v plus the full nightly semver (for example v1.1.0-nightly.20260501.17). The Release Notes link targets a tag that does not exist for current builds.
Reviewed by Cursor Bugbot for commit 5f6f683. Configure here.
|
🚀 Expo continuous deployment is ready!
|
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo Closing this PR after an automated pass over open pull requests. Trusted maintainer proposal, but desktop release notes already shipped in #3832. |
2 participants
Got inspired by VSCode:
What Changed
Why
UI Changes
Checklist
Note
Low Risk
UI-only change to desktop update tooltips and external link handling; no auth, data, or updater core logic changes.
Overview
Desktop update affordances in the sidebar pill and Settings → About now show a VS Code–style tooltip instead of a one-line string.
The new
DesktopUpdateTooltipPopupsurfaces a status title, the existing tooltip summary, current and latest versions, and a Release Notes control that opens GitHub viashell.openExternal, with an error toast if that fails.getDesktopUpdateLatestVersionandgetDesktopUpdateReleaseNotesUrlbuild the correct tag URL for stable (v…) vs nightly (nightly-v…) channels, with a fallback to the releases index when no version is known; unit tests cover these helpers.Reviewed by Cursor Bugbot for commit 5f6f683. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
[!NOTE]
Add release notes tooltip to desktop update UI with version info and external link
DesktopUpdateTooltipPopupcomponent that replaces simple text tooltips in the sidebar update pill and settings About section with a richer UI showing current/latest versions, a state-derived title, and a 'Release Notes' button.getDesktopUpdateReleaseNotesUrlto build a tag-specific GitHub Releases URL based on update channel (nightly vs stable) andgetDesktopUpdateLatestVersionto resolve the newest known version from update state.api.shell.openExternaland shows an error toast on failure.Macroscope summarized 5f6f683.